Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965178AbaKNLDv (ORCPT ); Fri, 14 Nov 2014 06:03:51 -0500 Received: from mail-wg0-f46.google.com ([74.125.82.46]:38463 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964896AbaKNLDt (ORCPT ); Fri, 14 Nov 2014 06:03:49 -0500 Message-ID: <5465E18B.9080907@linaro.org> Date: Fri, 14 Nov 2014 11:03:39 +0000 From: Daniel Thompson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, Andrew Morton , patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal , Jason Wessel Subject: Re: [PATCH RESEND 3.18-rc3 v2 0/2] trace: kdb: Bug fixes for ftdump References: <1411554781-16751-1-git-send-email-daniel.thompson@linaro.org> <1415277716-19419-1-git-send-email-daniel.thompson@linaro.org> <20141106082728.5d4b7161@gandalf.local.home> <5460884C.1050401@linaro.org> <20141113211616.0b9fbcf1@gandalf.local.home> In-Reply-To: <20141113211616.0b9fbcf1@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/14 02:16, Steven Rostedt wrote: > On Mon, 10 Nov 2014 09:41:32 +0000 > Daniel Thompson wrote: > >> On 06/11/14 13:27, Steven Rostedt wrote: >>> On Thu, 6 Nov 2014 12:41:54 +0000 >>> Daniel Thompson wrote: >>> >>>> This patchset makes it possible to use kdb's ftdump command without >>>> panicing, crashing or livelocking. The ftdump command cannot be used >>>> at all without these changes. >>>> >>>> IIRC this patches are still pending Jason's ack. >>> >>> I haven't heard from Jason in a long time. Is he still active? >> >> [sorry for the delay, I wanted to give Jason a chance to answer this] >> >> Very occasionally. >> >> I can't find anything on lkml in the last three months, and I have >> unreviewed kdb patches that stretch back well beyond that. >> >> That said he still helps people on kgdb-bugreport@ from time-to-time >> (and as recently as last week). I've also had a little bit of private >> contact although nothing very recent. >> >> On that basis I'd say you shouldn't feel guilty if you have to accept a >> change here without an ack. >> > > He had more than enough time to respond. OK, I'll take it. > > Looking at the first patch, I notice that there's no protection of the > static buffer_iter array. I also noticed that there's no protection of > the static iter itself (which was there before your patch). I take it > that this code is not re-entrant. No. k(g)db halts all other processors before entering the command dispatch loop and it forces a kernel panic if the debugger is reentered by the same CPU. Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/