Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965310AbaKNLVp (ORCPT ); Fri, 14 Nov 2014 06:21:45 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:48510 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965084AbaKNLVn (ORCPT ); Fri, 14 Nov 2014 06:21:43 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <26e1870b897fee274709584504746198> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5465E5C0.7050207@rock-chips.com> Date: Fri, 14 Nov 2014 19:21:36 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Zubair Lutfullah Kakakhel , airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk CC: Mark Rutland , dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , mark.yao@rock-chips.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Philipp Zabel , Kumar Gala , Shawn Guo , Lucas Stach Subject: Re: [PATCH v10 11/11] drm: bridge/dw_hdmi: add rockchip rk3288 support References: <1415934583-16290-1-git-send-email-andy.yan@rock-chips.com> <1415935884-17130-1-git-send-email-andy.yan@rock-chips.com> <5465D816.3020708@imgtec.com> <5465DB4F.7090402@rock-chips.com> <5465DF34.303@imgtec.com> <5465E3F1.4060407@rock-chips.com> <5465E47E.7090602@imgtec.com> In-Reply-To: <5465E47E.7090602@imgtec.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月14日 19:16, Zubair Lutfullah Kakakhel wrote: > > On 14/11/14 11:13, Andy Yan wrote: >> On 2014年11月14日 18:53, Zubair Lutfullah Kakakhel wrote: >>> On 14/11/14 10:37, Andy Yan wrote: >>>> On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote: >>>>> Hi Andy >>>>> >>>>> On 14/11/14 03:31, Andy Yan wrote: >>>>>> Rockchip RK3288 hdmi is compatible with dw_hdmi >>>>>> >>>>>> Signed-off-by: Andy Yan >>>>>> >>>>>> --- >>>>>> >>>>>> Changes in v10: >>>>>> - add more display mode support mpll configuration for rk3288 >>>>>> >>>>>> Changes in v9: >>>>>> - move some phy configuration to platform driver >>>>>> >>>>>> Changes in v8: None >>>>>> Changes in v7: None >>>>>> Changes in v6: None >>>>>> Changes in v5: None >>>>>> Changes in v4: None >>>>>> Changes in v3: None >>>>>> Changes in v2: None >>>>>> >>>>>> drivers/gpu/drm/bridge/dw_hdmi.c | 10 + >>>>>> drivers/gpu/drm/bridge/dw_hdmi.h | 3 +- >>>>>> drivers/gpu/drm/rockchip/Kconfig | 10 + >>>>>> drivers/gpu/drm/rockchip/Makefile | 2 +- >>>>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++++++++++++++++++++ >>>>>> include/drm/bridge/dw_hdmi.h | 1 + >>>>>> 6 files changed, 379 insertions(+), 2 deletions(-) >>>>>> create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c >>>>>> >>>>>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >>>>>> index a2876fe..1dd1f0b 100644 >>>>>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >>>>>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >>>>>> @@ -715,6 +715,13 @@ static void dw_hdmi_phy_enable_tmds(struct dw_hdmi *hdmi, u8 enable) >>>>>> HDMI_PHY_CONF0_ENTMDS_MASK); >>>>>> } >>>>>> +static void dw_hdmi_phy_enable_spare(struct dw_hdmi *hdmi, u8 enable) >>>>>> +{ >>>>>> + hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0, >>>>>> + HDMI_PHY_CONF0_SPARECTRL_OFFSET, >>>>>> + HDMI_PHY_CONF0_SPARECTRL_MASK); >>>>>> +} >>>>>> + >>>>> What does enable spare do? Can other future SoCs use it? >>>>> >>>>> This looks like DW specific. And can be a separate commit that adds a feature to the dw hdmi driver. >>>> Actually I am not very clearly about this bit, but RK3288 HDMI will not work without this bit enable. >>>> On imx6, the description about this bit is:Reserved. Spare pin control. >>>> On rk3288, the description is: svsret/sparectrl >>>> Both are very simple. >>> Sounds like the IP Core in the rk3288 is slightly upgraded. >>> Separate this section in a different commit as it is generic DW stuff. >>> >>> And add what you wrote above in the commit message. >> Only Separate function dw_hdmi_phy_enale_spare ? not include >> if (hdmi->dev_type == rk3288_hdmi) >> dw_hdmi_enable_phy_spare(hdmi, 1); >> ? > Yes. Separate dw_hdmi_phy_enable_spare and its associated defines > HDMI_PHY_CONF0_SPARECTRL_OFFSET > HDMI_PHY_CONF0_SPARECTRL_MASK > in the header > as one commit. > > > The if (hdmi->dev_type == rk3288_hdmi) code is part of the add rk3288 support. > > ZubairLK Many thanks :-) > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/