Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965435AbaKNNcw (ORCPT ); Fri, 14 Nov 2014 08:32:52 -0500 Received: from mail-qg0-f44.google.com ([209.85.192.44]:32875 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965283AbaKNNcv (ORCPT ); Fri, 14 Nov 2014 08:32:51 -0500 From: Paul Moore To: Richard Guy Briggs , Paul Moore CC: , , , Date: Fri, 14 Nov 2014 08:32:48 -0500 Message-ID: <149ae818c30.2806.85c95baa4474aabc7814e68940a78392@paul-moore.com> In-Reply-To: <20141114010852.GB5960@madcap2.tricolour.ca> References: <1745832.tbkjBzSGxr@sifl> <20141114010852.GB5960@madcap2.tricolour.ca> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 AquaMail/1.5.0.19 (build: 2100846) Subject: Re: [PATCH] audit: convert status version to a feature bitmap MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My apologies, yes I was concerned about LATEST. Try the test that Steve described and if that works I'm happy. -- paul moore www.paul-moore.com On November 13, 2014 8:09:11 PM Richard Guy Briggs wrote: > On 14/11/13, Paul Moore wrote: > > On Thursday, November 13, 2014 03:29:10 PM Richard Guy Briggs wrote: > > > The version field defined in the audit status structure was found to have > > > limitations in terms of its expressibility of features supported. This is > > > distict from the get/set features call to be able to command those features > > > that are present. > > > > > > Converting this field from a version number to a feature bitmap will allow > > > distributions to selectively backport and support certain features and will > > > allow upstream to be able to deprecate features in the future. It will > > > allow userspace clients to first query the kernel for which features are > > > actually present and supported. Currently, EINVAL is returned rather than > > > EOPNOTSUP, which isn't helpful in determining if there was an error in the > > > command, or if it simply isn't supported yet. Past features are not > > > represented by this bitmap, but their use may be converted to EOPNOTSUP if > > > needed in the future. > > > > > > Since "version" is too generic to convert with a #define, use a union > in the > > > struct status, introducing the member "feature_bitmap" unionized with > > > "version". > > > > > > Convert existing AUDIT_VERSION_* macros over to AUDIT_FEATURE_BITMAP* > > > counterparts, leaving the former for backwards compatibility. > > > > > > Signed-off-by: Richard Guy Briggs > > > --- > > > include/uapi/linux/audit.h | 17 +++++++++++++---- > > > kernel/audit.c | 2 +- > > > 2 files changed, 14 insertions(+), 5 deletions(-) > > > > Looks good for the most part, just a naming nit pick and a question about the > > deprecated AUDIT_VERSION_* defines; see below ... > > > > > diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h > > > index 4d100c8..74aa584 100644 > > > --- a/include/uapi/linux/audit.h > > > +++ b/include/uapi/linux/audit.h > > > @@ -322,9 +322,15 @@ enum { > > > #define AUDIT_STATUS_BACKLOG_LIMIT 0x0010 > > > #define AUDIT_STATUS_BACKLOG_WAIT_TIME 0x0020 > > > > > > -#define AUDIT_VERSION_BACKLOG_LIMIT 1 > > > -#define AUDIT_VERSION_BACKLOG_WAIT_TIME 2 > > > -#define AUDIT_VERSION_LATEST AUDIT_VERSION_BACKLOG_WAIT_TIME > > > +#define AUDIT_FEATURE_BITMAP_BACKLOG_LIMIT 0x00000001 > > > +#define AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_TIME 0x00000002 > > > +#define AUDIT_FEATURE_BITMAP ( AUDIT_FEATURE_BITMAP_BACKLOG_LIMIT | \ > > > + AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_TIME ) > > > > How about AUDIT_FEATURE_BIMAP_ALL instead of just AUDIT_FEATURE_BITMAP? > > Sure, I'm fine with that. > > > > +/* deprecated: AUDIT_VERSION_* */ > > > +#define AUDIT_VERSION_LATEST AUDIT_FEATURE_BITMAP > > > +#define AUDIT_VERSION_BACKLOG_LIMIT AUDIT_FEATURE_BITMAP_BACKLOG_LIMIT > > > +#define AUDIT_VERSION_BACKLOG_WAIT_TIME > > > ... AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_TIME > > > > So what terrible things happen to userspace if > AUDIT_VERSION_BACKLOG_WAIT_TIME > > becomes 0x03 instead of 0x02? > > But it won't. It gets the value of > AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_TIME, which is 0x00000002. > > I think you meant to ask about AUDIT_VERSION_LATEST, which would become 3. > > You *did* already ask that question in a previous thread, and there > didn't seem to be a concern. Steve Grubb could likely answer this > question better than me. > > > paul moore > > - RGB > > -- > Richard Guy Briggs > Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, > Red Hat > Remote, Ottawa, Canada > Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/