Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965639AbaKNPRT (ORCPT ); Fri, 14 Nov 2014 10:17:19 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:46845 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S965425AbaKNPRR (ORCPT ); Fri, 14 Nov 2014 10:17:17 -0500 Date: Fri, 14 Nov 2014 10:17:16 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Benson Leung cc: johan@kernel.org, Jiri Kosina , , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sameer Nanda Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Nov 2014, Benson Leung wrote: > Hi Alan, > > On Thu, Nov 13, 2014 at 2:11 PM, Alan Stern wrote: > > Wait a minute -- in your previous email you said this approach didn't > > work. So does it work or doesn't it? > > Sorry for the confusion. The approach *does* work. > > That was actually my original idea to fix the problem, but I saw other > places in the kernel where it was done with a get/put. The reason for the get/put is to force a call to autosuspend_check(). But in this case, if killing the interrupt URB causes autosuspend_check() to run then the get/put isn't needed. On the other hand, I don't see why killing the interrupt URB would cause autosuspend_check() to run. Can you explain that? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/