Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161264AbaKNQwU (ORCPT ); Fri, 14 Nov 2014 11:52:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48484 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965580AbaKNQwS (ORCPT ); Fri, 14 Nov 2014 11:52:18 -0500 From: Jeff Moyer To: Dave Jones Cc: Dave Chinner , Milosz Tanski , linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo , "Theodore Ts'o" , Al Viro , linux-api@vger.kernel.org, Michael Kerrisk , linux-arch@vger.kernel.org Subject: Re: [PATCH v6 0/7] vfs: Non-blockling buffered fs read (page cache only) References: <20141111064417.GT23575@dastard> <20141114163912.GA23769@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 14 Nov 2014 11:51:31 -0500 In-Reply-To: <20141114163912.GA23769@redhat.com> (Dave Jones's message of "Fri, 14 Nov 2014 11:39:12 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Jones writes: > On Fri, Nov 14, 2014 at 11:32:53AM -0500, Jeff Moyer wrote: > > > > Can you write a test (or set of) for fstests that exercises this new > > > functionality? I'm not worried about performance, just > > > correctness.... > > > > On the subject of testing, I added support to trinity (attached, > > untested). That did raise one question. Do we expect applications to > > #include to get the RWF_NONBLOCK definition? > > Trinity will at least need an addition to include/compat.h for > older headers that won't have the definition. Looks ok otherwise. OK, I'll add that. > Also, I usually sit on stuff like this until the syscall numbers are > in Linus tree. This is 3.19 stuff I presume ? > istr akpm picked up execveat recently, so if that goes in first, we'll > need to respin this anyway.. Sure. I just wanted to test with trinity *before* it makes it into the kernel. Crazy, I know. ;-) Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/