From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Feng Kan <fkan@apm.com>, =devicetree@vger.kernel.org,
        patches <patches@apm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bao Truong <btruong@apm.com>
Subject: Re: [PATCH V2 1/7] arm64: dts: Add APM X-Gene USB DTS node
Date: Fri, 14 Nov 2014 20:58:43 +0100
Message-ID: <13891778.lvGnz7oB4J@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAL85gmCXBFCs6dNQXDLh4HAgZ4SN7Wwnon_D3a4q_Rq3oz-Vvg@mail.gmail.com>
References: <1415924401-3013-1-git-send-email-fkan@apm.com> <2126031.OOHBs2pzVu@wuerfel> <CAL85gmCXBFCs6dNQXDLh4HAgZ4SN7Wwnon_D3a4q_Rq3oz-Vvg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org

On Friday 14 November 2014 11:17:38 Feng Kan wrote:
> On Fri, Nov 14, 2014 at 7:04 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Thursday 13 November 2014 16:19:55 Feng Kan wrote:
> >>
> >> +               usb0: dwusb@19000000 {
> >> +                       status = "disabled";
> >> +                       compatible = "xhci-platform";
> >> +                       reg =  <0x0 0x19000000 0x0 0x100000>;
> >> +                       interrupts = <0x0 0x89 0x4>;
> >> +                       dma-coherent;
> >> +               };
> >> +
> >> +               usb1: dwusb@19800000 {
> >> +                       status = "disabled";
> >> +                       compatible = "xhci-platform";
> >> +                       reg =  <0x0 0x19800000 0x0 0x100000>;
> >> +                       interrupts = <0x0 0x8a 0x4>;
> >> +                       dma-coherent;
> >> +               };
> >>
> >
> > Call the nodes 'usb', not 'dwusb'.
> This was a deliberate change on our part to make sure backward
> compatibility with a older bootloader.

Ok, then add a comment above the nodes explaining this, to prevent
people from cleaning it up and accidentally breaking your boot loader
later.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/