Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422834AbaKNWQr (ORCPT ); Fri, 14 Nov 2014 17:16:47 -0500 Received: from mail-ie0-f180.google.com ([209.85.223.180]:52589 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161930AbaKNWQp (ORCPT ); Fri, 14 Nov 2014 17:16:45 -0500 Date: Fri, 14 Nov 2014 14:16:42 -0800 From: Dmitry Torokhov To: Thomas Gleixner Cc: Jason Cooper , Florian Fainelli , Arnd Bergmann , Kevin Cernekee , Brian Norris , linux-kernel@vger.kernel.org Subject: [PATCH] irqchip: brcmstb-l2: fix error handling of irq_of_parse_and_map Message-ID: <20141114221642.GA37468@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual code inspection. drivers/irqchip/irq-brcmstb-l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c index 4aa653a..313c2c6 100644 --- a/drivers/irqchip/irq-brcmstb-l2.c +++ b/drivers/irqchip/irq-brcmstb-l2.c @@ -139,9 +139,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np, writel(0xffffffff, data->base + CPU_CLEAR); data->parent_irq = irq_of_parse_and_map(np, 0); - if (data->parent_irq < 0) { + if (!data->parent_irq) { pr_err("failed to find parent interrupt\n"); - ret = data->parent_irq; + ret = -EINVAL; goto out_unmap; } -- 2.1.0.rc2.206.gedb03e5 -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/