Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755061AbaKOFmk (ORCPT ); Sat, 15 Nov 2014 00:42:40 -0500 Received: from message.langara.bc.ca ([209.87.29.115]:60480 "EHLO message.langara.bc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbaKOFmf (ORCPT ); Sat, 15 Nov 2014 00:42:35 -0500 X-Greylist: delayed 3600 seconds by postgrey-1.27 at vger.kernel.org; Sat, 15 Nov 2014 00:42:35 EST MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-disposition: inline Content-type: text/plain; charset=us-ascii From: Steven Stewart-Gallus To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso , Manfred Spraul , "J. Bruce Fields" , Doug Ledford , linux-newbie@vger.kernel.org Message-id: Date: Sat, 15 Nov 2014 04:42:34 +0000 (GMT) X-Mailer: Sun Java(tm) System Messenger Express 6.3-6.03 (built Mar 14 2008; 32bit) Content-language: en Subject: Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks X-Accept-Language: en In-reply-to: <20141111162146.6e72c3fb0858df4945096c47@linux-foundation.org> References: <20141111162146.6e72c3fb0858df4945096c47@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, thank you for the criticism. > It's probably better to do this as three or four separate patches. Really? Alright if you insist I'll do the next version as multiple patches. > Well yes, that's what EMFILE means but "too_many_open_files" doesn't > make sense in this context! Fair enough, I'll rename it in the next version. > Thatsabug. It only requires CAP_SYS_RESOURCE if we're trying with > queues_count >= queues_max. Right, that was dumb of me. > This test isn't really needed. I don't follow. If the queue creation is not rejected then the resource user has to be accounted for right? And we can't add the resource to accounting if it is not created right? Thank you, Steven Stewart-Gallus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/