Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755330AbaKOHQR (ORCPT ); Sat, 15 Nov 2014 02:16:17 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:35647 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbaKOHQO (ORCPT ); Sat, 15 Nov 2014 02:16:14 -0500 Date: Sat, 15 Nov 2014 08:16:06 +0100 From: Alexander Aring To: Alexey Khoroshilov Cc: "David S . Miller" , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] ieee802154: fix error handling in ieee802154fake_probe() Message-ID: <20141115071603.GA3481@omega> References: <1416006719-3450-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1416006719-3450-1-git-send-email-khoroshilov@ispras.ru> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Nov 15, 2014 at 02:11:59AM +0300, Alexey Khoroshilov wrote: > In case of any failure ieee802154fake_probe() just calls unregister_netdev(). > But it does not look safe to unregister netdevice before it was registered. > > The patch implements straightforward resource deallocation in case of > failure in ieee802154fake_probe(). > > Found by Linux Driver Verification project (linuxtesting.org). > Thanks for the patch! But I already delete the whole fakehard driver. The patch to remove this driver is already in net-next. There was too many issues with the fake hardMAC drivers and we don't really supported a "real" hardMAC transceiver. For my rework to grab the good things from wireless implementation and put 802.15.4 functionality on it I simple delete the whole driver and _maybe_ add a new one with the new introduced interfaces for possible hardMAC functionality. This patch could go into bluetooth(net)/stable but I don't think that there are many users for this driver. - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/