Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753935AbaKOH6h (ORCPT ); Sat, 15 Nov 2014 02:58:37 -0500 Received: from senator.holtmann.net ([87.106.208.187]:52082 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbaKOH6g convert rfc822-to-8bit (ORCPT ); Sat, 15 Nov 2014 02:58:36 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Subject: Re: [PATCH] ieee802154: fix error handling in ieee802154fake_probe() From: Marcel Holtmann In-Reply-To: <20141115071603.GA3481@omega> Date: Sat, 15 Nov 2014 16:58:28 +0900 Cc: Alexey Khoroshilov , linux-wpan@vger.kernel.org, Network Development , linux-kernel , ldv-project@linuxtesting.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1416006719-3450-1-git-send-email-khoroshilov@ispras.ru> <20141115071603.GA3481@omega> To: Alexander Aring , "David S. Miller" X-Mailer: Apple Mail (2.1990.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, >> In case of any failure ieee802154fake_probe() just calls unregister_netdev(). >> But it does not look safe to unregister netdevice before it was registered. >> >> The patch implements straightforward resource deallocation in case of >> failure in ieee802154fake_probe(). >> >> Found by Linux Driver Verification project (linuxtesting.org). >> > > Thanks for the patch! But I already delete the whole fakehard driver. > The patch to remove this driver is already in net-next. > > There was too many issues with the fake hardMAC drivers and we don't > really supported a "real" hardMAC transceiver. For my rework to grab the > good things from wireless implementation and put 802.15.4 functionality > on it I simple delete the whole driver and _maybe_ add a new one with > the new introduced interfaces for possible hardMAC functionality. > > This patch could go into bluetooth(net)/stable but I don't think that > there are many users for this driver. I am not sure that this is worth it then. Dave, do you want to just take it via net-stable tree? We currently have no urgent bluetooth-stable tree patches pending. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/