MIME-Version: 1.0
In-Reply-To: <20141114221614.GA37395@dtor-ws>
References: <20141114221614.GA37395@dtor-ws>
From: Kevin Cernekee <cernekee@gmail.com>
Date: Sat, 15 Nov 2014 11:42:40 -0800
Message-ID: <CAJiQ=7Dr0LdvqYC8inZ9PQ5T+5jzo+nOieg=dnwkwGvh0uwyAw@mail.gmail.com>
Subject: Re: [PATCH] irqchip: bcm7120-l2: fix error handling of irq_of_parse_and_map
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>,
        Arnd Bergmann <arnd@arndb.de>, Florian Fainelli <f.fainelli@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Nov 14, 2014 at 2:16 PM, Dmitry Torokhov <dtor@chromium.org> wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> ---
>
> Not tested, found by casual code inspection.
>
>  drivers/irqchip/irq-bcm7120-l2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-bcm7120-l2.c b/drivers/irqchip/irq-bcm7120-l2.c
> index e7c6155..8eec8e1 100644
> --- a/drivers/irqchip/irq-bcm7120-l2.c
> +++ b/drivers/irqchip/irq-bcm7120-l2.c
> @@ -102,9 +102,9 @@ static int bcm7120_l2_intc_init_one(struct device_node *dn,
>         unsigned int idx;
>
>         parent_irq = irq_of_parse_and_map(dn, irq);
> -       if (parent_irq < 0) {
> +       if (!parent_irq) {
>                 pr_err("failed to map interrupt %d\n", irq);
> -               return parent_irq;
> +               return -EINVAL;
>         }
>
>         /* For multiple parent IRQs with multiple words, this looks like:

Hi Dmitry,

Thanks for the review.  For this patch and for your irq-brcmstb-l2.c
patch, I'll add:

Tested-by: Kevin Cernekee <cernekee@gmail.com>

The same bug also showed up in my new irq-bcm7038-l1.c driver; it will
be fixed in the initial submission.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/