Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275AbaKQBfh (ORCPT ); Sun, 16 Nov 2014 20:35:37 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:47369 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751928AbaKQBff (ORCPT ); Sun, 16 Nov 2014 20:35:35 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: galak@codeaurora.org X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <546950D5.20703@rock-chips.com> Date: Mon, 17 Nov 2014 09:35:17 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Daniel Kurtz CC: David Airlie , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk, Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, Yakir Yang , "linux-kernel@vger.kernel.org" , dri-devel , devel@driverdev.osuosl.org, "open list:OPEN FIRMWARE AND..." , "open list:ARM/Rockchip SoC..." , Xu Jianqun , Pawel Moll , "mark.yao@rock-chips.com" , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH v11 02/12] staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter References: <1415972231-8283-1-git-send-email-andy.yan@rock-chips.com> <1415972348-8382-1-git-send-email-andy.yan@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月15日 13:41, Daniel Kurtz wrote: > On Fri, Nov 14, 2014 at 9:39 PM, Andy Yan wrote: >> drm driver may probe before the i2c bus, so the driver should >> defer probing until it is available >> >> Signed-off-by: Andy Yan >> >> --- >> >> Changes in v11: None >> Changes in v10: None >> Changes in v9: None >> Changes in v8: None >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: >> - defer probe ddc i2c adapter >> >> Changes in v3: None >> Changes in v2: None >> >> drivers/staging/imx-drm/imx-hdmi.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/imx-drm/imx-hdmi.c b/drivers/staging/imx-drm/imx-hdmi.c >> index 79daec4..c2b035a 100644 >> --- a/drivers/staging/imx-drm/imx-hdmi.c >> +++ b/drivers/staging/imx-drm/imx-hdmi.c >> @@ -1611,8 +1611,11 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data) >> ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0); >> if (ddc_node) { >> hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node); >> - if (!hdmi->ddc) >> + if (!hdmi->ddc) { >> dev_dbg(hdmi->dev, "failed to read ddc node\n"); >> + of_node_put(ddc_node); >> + return -EPROBE_DEFER; >> + } > Nit: You could move "of_node_put()" above "if (!hdmi->ddc)", and not > need it in two places. thanks, I will take your advice > > Either way, this one is: > Reviewed-by: Daniel Kurtz > >> of_node_put(ddc_node); >> } else { >> -- >> 1.9.1 >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/