Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751734AbaKQIxa (ORCPT ); Mon, 17 Nov 2014 03:53:30 -0500 Received: from mga11.intel.com ([192.55.52.93]:53677 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbaKQIx2 (ORCPT ); Mon, 17 Nov 2014 03:53:28 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,401,1413270000"; d="scan'208";a="623463957" Message-ID: <5469B828.90401@intel.com> Date: Mon, 17 Nov 2014 09:56:08 +0100 From: Loic Poulain Organization: Intel Corporation SAS - RCS Nanterre B 302 456 199 - 2 rue de Paris, 92196 Meudon Cedex, France User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Doug Anderson CC: Greg Kroah-Hartman , Heiko Stuebner , Jiri Slaby , Chris Zhong , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Andrew Bresticker , mika.westerberg@linux.intel.com, heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com, wens@csie.org, alan@linux.intel.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250_dw: Handle no_console_suspend when uart loses state References: <1416011556-23422-1-git-send-email-dianders@chromium.org> In-Reply-To: <1416011556-23422-1-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In certain suspend modes on certain boards the 8250 UART may lose > state when the device goes to suspend. If we're using > no_console_suspend this can cause lots of problems during resume. > > Let's cache the basic UART config registers at suspend time and if we > notice that the UART loses state (by looking at a canary stored in the > scratch register) we'll restore it. If I'm not wrong, it's already done in acpi_lpss suspend/resume (for 8250_dw). Commit c78b0830667a7e7c1f0ca65b76b33166a84806b3. Regards, Loic -- Intel Open Source Technology Center http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/