Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057AbaKQKEN (ORCPT ); Mon, 17 Nov 2014 05:04:13 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:43819 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbaKQKEM (ORCPT ); Mon, 17 Nov 2014 05:04:12 -0500 MIME-Version: 1.0 In-Reply-To: <20141117092456.GA3247@distanz.ch> References: <20141114220419.GA32497@dtor-ws> <20141117092456.GA3247@distanz.ch> Date: Mon, 17 Nov 2014 18:04:10 +0800 X-Google-Sender-Auth: 6YJgUejRdKCt_6rbqQ2frDFBsF8 Message-ID: Subject: Re: [PATCH] nios2: fix error handling of irq_of_parse_and_map From: Ley Foon Tan To: Tobias Klauser Cc: Dmitry Torokhov , "nios2-dev@lists.rocketboards.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 17, 2014 at 5:24 PM, Tobias Klauser wrote: > On 2014-11-14 at 23:04:19 +0100, Dmitry Torokhov wrote: >> Return value of irq_of_parse_and_map() is unsigned int, with 0 >> indicating failure, so testing for negative result never works. >> >> Signed-off-by: Dmitry Torokhov > > Reviewed-by: Tobias Klauser > > Thanks for catching this. Thanks for your patch. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/