Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbaKQPki (ORCPT ); Mon, 17 Nov 2014 10:40:38 -0500 Received: from mga01.intel.com ([192.55.52.88]:32135 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbaKQPkg (ORCPT ); Mon, 17 Nov 2014 10:40:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,403,1413270000"; d="scan'208";a="623625567" Date: Mon, 17 Nov 2014 17:40:28 +0200 From: Heikki Krogerus To: Vivek Gautam Cc: Kishon Vijay Abraham I , Vivek Gautam , "linux-kernel@vger.kernel.org" , Linux USB Mailing List , andrew.kim@intel.com Subject: Re: [PATCHv4 2/6] phy: improved lookup method Message-ID: <20141117154028.GD7512@kuha.fi.intel.com> References: <1413556756-5050-1-git-send-email-heikki.krogerus@linux.intel.com> <1413556756-5050-3-git-send-email-heikki.krogerus@linux.intel.com> <5461AFD3.5020302@ti.com> <5461CDDF.4090209@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote: > How about adding the change in attached patch [1] on top of this patch. > Just introduced the phy pointer in "phy_lookup" structure, and > modified phy_find() accordingly. I would be fine if we used the phy pointer to match, but if we have the pointer to the phy in the lookup, then I would say we need to remove the phy_name member. Otherwise we would have to support two ways of finding the lookups (one for the "static" lookups where we match to the phy_name and other where we match to the pointer). That means we will also not be able to create "static" lookups, but those would be only needed if we wanted to create them in board files. I don't think there will ever be need to create the lookups in board files, so I'm more then happy to remove the static way of creating the lookups. Kishon, if you are OK with this change, I'll prepare new version of this set and use the idea. Vivek, you'll get the credit for it. Thanks! -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/