Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbaKQUwa (ORCPT ); Mon, 17 Nov 2014 15:52:30 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38790 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622AbaKQUw2 (ORCPT ); Mon, 17 Nov 2014 15:52:28 -0500 Message-ID: <1416257530.4494.0.camel@localhost> Subject: Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks From: Davidlohr Bueso To: Manfred Spraul Cc: Steven Stewart-Gallus , linux-kernel@vger.kernel.org, Andrew Morton , "J. Bruce Fields" , Doug Ledford , linux-newbie@vger.kernel.org Date: Mon, 17 Nov 2014 12:52:10 -0800 In-Reply-To: <546A47C6.4030309@colorfullife.com> References: <1415780201.24725.2.camel@linux-t7sj.site> <1416086539.12597.15.camel@linux-t7sj.site> <546A47C6.4030309@colorfullife.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-11-17 at 20:08 +0100, Manfred Spraul wrote: > Hi Steven, > > On 11/16/2014 08:40 PM, Steven Stewart-Gallus wrote: > > Finally, please don't ignore the rest of my message. Even if my patch > > isn't that good there are lots of ways to compromise and improve it > > such as adding tests, annotations and making it clearer. > > I think you were already given ideas how to improve the patch: > > a) split the patch. > > b) create test cases so that you are able to check that the code still > behaves as it did before Adding/improving ipc kselftests would also be very welcome. Thanks, Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/