Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753001AbaKQVcg (ORCPT ); Mon, 17 Nov 2014 16:32:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45412 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbaKQVce (ORCPT ); Mon, 17 Nov 2014 16:32:34 -0500 Date: Mon, 17 Nov 2014 16:32:23 -0500 From: Benjamin Tissoires To: Antonio Borneo Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jean-Baptiste Maneyrol Subject: Re: [PATCH] HID: i2c-hid: print the correct data in dbg msg Message-ID: <20141117213223.GB30324@mail.corp.redhat.com> References: <1416149143-25703-1-git-send-email-borneo.antonio@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1416149143-25703-1-git-send-email-borneo.antonio@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 16 2014 or thereabouts, Antonio Borneo wrote: > From: Jean-Baptiste Maneyrol > > From: Jean-Baptiste Maneyrol > > Report is received in "buffer"; fix the following i2c_hid_dbg() > to dump data from the correct pointer. > > Signed-off-by: Jean-Baptiste Maneyrol > [Antonio Borneo: cleanup and rebase to v3.17] > Signed-off-by: Antonio Borneo > --- Good catch. This one is Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/i2c-hid/i2c-hid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 747d544..933bf10 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -437,7 +437,7 @@ static void i2c_hid_init_report(struct hid_report *report, u8 *buffer, > report->id, buffer, size)) > return; > > - i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf); > + i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, buffer); > > ret_size = buffer[0] | (buffer[1] << 8); > > -- > 2.1.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/