Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbaKRALu (ORCPT ); Mon, 17 Nov 2014 19:11:50 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:59961 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbaKRALs (ORCPT ); Mon, 17 Nov 2014 19:11:48 -0500 Message-ID: <546A8EA9.5070001@kapsi.fi> Date: Tue, 18 Nov 2014 02:11:21 +0200 From: Mikko Perttunen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Eduardo Valentin , Linux PM CC: Caesar Wang , Wei Ni , Lukasz Majewski , Alexandre Courbot , devicetree@vger.kernel.org, Grant Likely , Guenter Roeck , Jean Delvare , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, lm-sensors@lm-sensors.org, Rob Herring , Stephen Warren , Thierry Reding , Zhang Rui Subject: Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API References: <1416263769-6578-2-git-send-email-edubezval@gmail.com> <1416264255-10083-1-git-send-email-edubezval@gmail.com> In-Reply-To: <1416264255-10083-1-git-send-email-edubezval@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:708:30:12d0:beee:7bff:fe5b:f272 X-SA-Exim-Mail-From: mikko.perttunen@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2014 12:44 AM, Eduardo Valentin wrote: > Different drivers request API extensions in of-thermal. For this reason, > additional callbacks are required to fit the new drivers needs. > > The current API implementation expects the registering sensor driver > to provide a get_temp and get_trend callbacks as function parameters. > As the amount of callbacks is growing, this patch changes the existing > implementation to use a .ops field to hold all the of thermal callbacks > to sensor drivers. > > This patch also changes the existing of-thermal users to fit the new > API design. No functional change is introduced in this patch. > > Cc: Alexandre Courbot > Cc: devicetree@vger.kernel.org > Cc: Grant Likely > Cc: Guenter Roeck > Cc: Jean Delvare > Cc: linux-kernel@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Cc: lm-sensors@lm-sensors.org > Cc: Rob Herring > Cc: Stephen Warren > Cc: Thierry Reding > Cc: Zhang Rui > Signed-off-by: Eduardo Valentin > --- > > Difference from V1: > - Fix error handling when .get_trend is not provided. > > --- > drivers/hwmon/lm75.c | 9 +++-- > drivers/hwmon/ntc_thermistor.c | 6 +++- > drivers/hwmon/tmp102.c | 6 +++- > drivers/thermal/of-thermal.c | 41 +++++++++------------- > drivers/thermal/tegra_soctherm.c | 7 ++-- > drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 8 +++-- > include/linux/thermal.h | 24 +++++++++---- > 7 files changed, 62 insertions(+), 39 deletions(-) > > ... > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > index 70f7e9e..893c39c 100644 > --- a/drivers/thermal/tegra_soctherm.c > +++ b/drivers/thermal/tegra_soctherm.c > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp) > return 0; > } > > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = { > + .get_trend = tegra_thermctl_get_temp, > +}; This should probably read ".get_temp = tegra_thermctl_get_temp" instead of .get_trend :) > ... Cheers, Mikko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/