Message-ID: <1416272878.29010.8.camel@perches.com>
Subject: Re: [PATCH 20/26 v5] seq_buf: Add seq_buf_can_fit() helper function
From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jiri Kosina <jkosina@suse.cz>, Petr Mladek <pmladek@suse.cz>
Date: Mon, 17 Nov 2014 17:07:58 -0800
In-Reply-To: <20141117195651.27c79369@gandalf.local.home>
References: <20141115045847.712848224@goodmis.org>
	 <20141115050604.073390701@goodmis.org>
	 <20141117123642.1de9252e@gandalf.local.home>
	 <1416269253.29010.4.camel@perches.com>
	 <20141117192733.0ab1ba2e@gandalf.local.home>
	 <1416270932.29010.6.camel@perches.com>
	 <20141117195651.27c79369@gandalf.local.home>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-11-17 at 19:56 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2014 16:35:32 -0800
> Joe Perches <joe@perches.com> wrote:
> 
>  
> > What "logic" does it place in one place and
> > how does it matter?
> 
> Look at the next patch.

I don't have it and you are not cc'ing me.
I think you are getting carried away with the helpers.

> > I don't see it making mistakes more or less
> > likely, I just see it being used to avoid
> > setting the overflow state which seems like
> > more of an error than anything else.
> > 
> > Why avoid setting overflow at all?
[]
> It has nothing to do with overflow. Where did you get that from?

writing to seq_buf really only cares about overflow.

seq_buf -> write to buffer -> overflowed?
expand buffer, redo everything else when finished,
dump buffer

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/