Date: Tue, 18 Nov 2014 15:06:34 +0100
From: Petr Mladek <pmladek@suse.cz>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 08/26 v5] tracing: Do not check return values of
 trace_seq_p*() for mmio tracer
Message-ID: <20141118140634.GD23958@pathway.suse.cz>
References: <20141115045847.712848224@goodmis.org>
 <20141115050602.001652351@goodmis.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141115050602.001652351@goodmis.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Fri 2014-11-14 23:58:55, Steven Rostedt wrote:
> From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
> 
> The return values for trace_seq_printf() and friends are going to be
> removed and they will become void functions. The mmio tracer checked
> their return and even did so incorrectly.
> 
> Some of the funtions which returned the values were never checked
> themselves. Removing all the checks simplifies the code.
> 
> Use trace_seq_has_overflowed() and trace_handle_return() where
> necessary instead.
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Reviewed-by: Petr Mladek <pmladek@suse.cz>

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/