Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755974AbaKRPpn (ORCPT ); Tue, 18 Nov 2014 10:45:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44647 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020AbaKRPpl (ORCPT ); Tue, 18 Nov 2014 10:45:41 -0500 Message-ID: <546B694D.3080604@redhat.com> Date: Tue, 18 Nov 2014 07:44:13 -0800 From: Alexander Duyck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: David Laight , "linux-arch@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: "mathieu.desnoyers@polymtl.ca" , "peterz@infradead.org" , "benh@kernel.crashing.org" , "heiko.carstens@de.ibm.com" , "mingo@kernel.org" , "mikey@neuling.org" , "linux@arm.linux.org.uk" , "donald.c.skidmore@intel.com" , "matthew.vick@intel.com" , "geert@linux-m68k.org" , "jeffrey.t.kirsher@intel.com" , "romieu@fr.zoreil.com" , "paulmck@linux.vnet.ibm.com" , "nic_swsd@realtek.com" , "will.deacon@arm.com" , "michael@ellerman.id.au" , "tony.luck@intel.com" , "torvalds@linux-foundation.org" , "oleg@redhat.com" , "schwidefsky@de.ibm.com" , "fweisbec@gmail.com" , "davem@davemloft.net" Subject: Re: [PATCH 0/4] Add lightweight memory barriers fast_rmb() and fast_wmb() References: <20141117171005.22333.96544.stgit@ahduyck-server> <063D6719AE5E284EB5DD2968C1650D6D1C9F2930@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1C9F2930@AcuExch.aculab.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2014 01:57 AM, David Laight wrote: > From: Alexander Duyck >> These patches introduce two new primitives for synchronizing cache-enabled >> memory writes and reads. These two new primitives are: >> >> fast_rmb() >> fast_wmb() > Not sure I like the names. > If the aim is to sync data into the local cache so that hardware > that is doing cache-snooping accesses sees the data then maybe > local_rmb() and local_wmb() Yeah, that is the general consensus. I am planning to change them to coherent_rmb() and coherent_wmb(). > IIRC read_barrier_depends() is a nop on everything except alpha. > Maybe add the default if it isn't defined by the MD file? > > David > From my patch the only two I saw define it were alpha and blackfin. It is already defined in asm-generic, the rest is just clean-up since I suspect some of the arch tree barrier.h calls just borrowed from asm-generic without sorting out what became redundancies. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/