Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755693AbaKRQFf (ORCPT ); Tue, 18 Nov 2014 11:05:35 -0500 Received: from lan.nucleusys.com ([92.247.61.126]:48767 "EHLO zztop.nucleusys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755650AbaKRQFc (ORCPT ); Tue, 18 Nov 2014 11:05:32 -0500 X-Greylist: delayed 2070 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Nov 2014 11:05:31 EST Date: Tue, 18 Nov 2014 17:30:42 +0200 From: Petko Manolov To: Sudip Mukherjee Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usbnet: rtl8150: remove unused variable Message-ID: <20141118153042.GB18659@vm-taos-petkan.jnpr.net> References: <1416315599-16939-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416315599-16939-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -1.0 (-) X-Spam-Report: Spam detection software, running on the system "zztop.nucleusys.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 14-11-18 18:29:59, Sudip Mukherjee wrote: > we were just returning the initial value of res, instead now > we are returning the value directly. Looks OK, but could you please fix the wording of the commit message to something like: [...] Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-11-18 18:29:59, Sudip Mukherjee wrote: > we were just returning the initial value of res, instead now > we are returning the value directly. Looks OK, but could you please fix the wording of the commit message to something like: Remove unused variable. This is a tiny patch and the code speaks for itself. Petko > Signed-off-by: Sudip Mukherjee > --- > drivers/net/usb/rtl8150.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > index 6e87e57..d37b7dc 100644 > --- a/drivers/net/usb/rtl8150.c > +++ b/drivers/net/usb/rtl8150.c > @@ -753,14 +753,13 @@ static int rtl8150_open(struct net_device *netdev) > static int rtl8150_close(struct net_device *netdev) > { > rtl8150_t *dev = netdev_priv(netdev); > - int res = 0; > > netif_stop_queue(netdev); > if (!test_bit(RTL8150_UNPLUG, &dev->flags)) > disable_net_traffic(dev); > unlink_all_urbs(dev); > > - return res; > + return 0; > } > > static void rtl8150_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info) > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/