Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755222AbaKRQmL (ORCPT ); Tue, 18 Nov 2014 11:42:11 -0500 Received: from mail.skyhub.de ([78.46.96.112]:44199 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319AbaKRQmI (ORCPT ); Tue, 18 Nov 2014 11:42:08 -0500 Date: Tue, 18 Nov 2014 17:42:05 +0100 From: Borislav Petkov To: Stephane Eranian Cc: Thomas Gleixner , x86-ml , LKML , Peter Zijlstra , "mingo@elte.hu" , "ak@linux.intel.com" , Jiri Olsa , "Liang, Kan" , Maria Dimakopoulou Subject: Re: [PATCH v3 13/13] perf/x86: add syfs entry to disable HT bug workaround Message-ID: <20141118164205.GE5238@pd.tnic> References: <1416251225-17721-1-git-send-email-eranian@google.com> <1416251225-17721-14-git-send-email-eranian@google.com> <20141117230232.GC25157@pd.tnic> <20141117235841.GD25157@pd.tnic> <20141118154308.GB5238@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 18, 2014 at 05:37:26PM +0100, Stephane Eranian wrote: > Does it need to bit a bitmask, as opposed to just a bug number (which could > be implemented as a bitmask)? > > >> enable_workaround: > >> - provide the bit number (of the workaround) to enable the workaround > > > > Right, writing the bit number could be part of the description message > > above - just so that users know how to control the interface. > > > writing the bug number.... Ah, ok, I see what you mean. I guess we can do increasing bug numbers. The mapping internally to bits in bitmasks or whatever fancy thing we do should remain hidden. So I'd guess assigning bug numbers to the bugs should be the only thing that's stable and user-visible... Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/