Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186AbaKRQtv (ORCPT ); Tue, 18 Nov 2014 11:49:51 -0500 Received: from smtp.citrix.com ([66.165.176.89]:32296 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511AbaKRQtu (ORCPT ); Tue, 18 Nov 2014 11:49:50 -0500 X-IronPort-AV: E=Sophos;i="5.07,410,1413244800"; d="scan'208";a="192551837" Date: Tue, 18 Nov 2014 16:49:21 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: CC: , , Ian Campbell , , , , , , Stefano Stabellini Subject: Re: [PATCH v9 05/13] arm: introduce is_device_dma_coherent In-Reply-To: Message-ID: References: <1415792454-23161-5-git-send-email-stefano.stabellini@eu.citrix.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping? On Fri, 14 Nov 2014, Stefano Stabellini wrote: > Russell, > this patch needs your feedback. > > - Stefano > > On Wed, 12 Nov 2014, Stefano Stabellini wrote: > > Introduce a boolean flag and an accessor function to check whether a > > device is dma_coherent. Set the flag from set_arch_dma_coherent_ops. > > > > Signed-off-by: Stefano Stabellini > > Signed-off-by: Catalin Marinas > > Reviewed-by: Catalin Marinas > > CC: linux@arm.linux.org.uk > > --- > > arch/arm/include/asm/device.h | 1 + > > arch/arm/include/asm/dma-mapping.h | 6 ++++++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h > > index dc662fc..4111592 100644 > > --- a/arch/arm/include/asm/device.h > > +++ b/arch/arm/include/asm/device.h > > @@ -17,6 +17,7 @@ struct dev_archdata { > > #ifdef CONFIG_ARM_DMA_USE_IOMMU > > struct dma_iommu_mapping *mapping; > > #endif > > + bool dma_coherent; > > }; > > > > struct omap_device; > > diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h > > index 85738b2..8c3b616 100644 > > --- a/arch/arm/include/asm/dma-mapping.h > > +++ b/arch/arm/include/asm/dma-mapping.h > > @@ -123,11 +123,17 @@ static inline unsigned long dma_max_pfn(struct device *dev) > > > > static inline int set_arch_dma_coherent_ops(struct device *dev) > > { > > + dev->archdata.dma_coherent = true; > > set_dma_ops(dev, &arm_coherent_dma_ops); > > return 0; > > } > > #define set_arch_dma_coherent_ops(dev) set_arch_dma_coherent_ops(dev) > > > > +static inline bool is_device_dma_coherent(struct device *dev) > > +{ > > + return dev->archdata.dma_coherent; > > +} > > + > > static inline dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr) > > { > > unsigned int offset = paddr & ~PAGE_MASK; > > -- > > 1.7.10.4 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/