Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932882AbaKRXHa (ORCPT ); Tue, 18 Nov 2014 18:07:30 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:60521 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932700AbaKRXH2 (ORCPT ); Tue, 18 Nov 2014 18:07:28 -0500 From: "Rafael J. Wysocki" To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8) Date: Wed, 19 Nov 2014 00:28:32 +0100 Message-ID: <3970319.cPmRxBPPro@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1416131820-7336-1-git-send-email-fabf@skynet.be> References: <1416131820-7336-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, November 16, 2014 10:57:00 AM Fabian Frederick wrote: > sizeof(u8) is always 1. > > Signed-off-by: Fabian Frederick Queued up for 3.19-rc1, thanks! > --- > drivers/acpi/utils.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c > index 371ac12..dd8ff63 100644 > --- a/drivers/acpi/utils.c > +++ b/drivers/acpi/utils.c > @@ -136,8 +136,7 @@ acpi_extract_package(union acpi_object *package, > break; > case 'B': > size_required += > - sizeof(u8 *) + > - (element->buffer.length * sizeof(u8)); > + sizeof(u8 *) + element->buffer.length; > tail_offset += sizeof(u8 *); > break; > default: > @@ -255,7 +254,7 @@ acpi_extract_package(union acpi_object *package, > memcpy(tail, element->buffer.pointer, > element->buffer.length); > head += sizeof(u8 *); > - tail += element->buffer.length * sizeof(u8); > + tail += element->buffer.length; > break; > default: > /* Should never get here */ > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/