Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754473AbaKSCFH (ORCPT ); Tue, 18 Nov 2014 21:05:07 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39256 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754206AbaKSCFD (ORCPT ); Tue, 18 Nov 2014 21:05:03 -0500 Date: Tue, 18 Nov 2014 18:05:02 -0800 From: Greg Kroah-Hartman To: "Kweh, Hock Leong" Cc: Matt Fleming , Ming Lei , "Fleming, Matt" , Sam Protsenko , Henrique de Moraes Holschuh , LKML , "linux-efi@vger.kernel.org" , "Ong, Boon Leong" Subject: Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort() Message-ID: <20141119020502.GC6054@kroah.com> References: <1414984030-13859-1-git-send-email-hock.leong.kweh@intel.com> <1414984030-13859-2-git-send-email-hock.leong.kweh@intel.com> <20141108190655.GA2638@kroah.com> <20141117151211.GB6810@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 18, 2014 at 06:31:38AM +0000, Kweh, Hock Leong wrote: > > -----Original Message----- > > From: Matt Fleming [mailto:matt@console-pimps.org] > > Sent: Monday, November 17, 2014 11:12 PM > > > > > > - Only doing module unload is required to be aware of this synchronization > > > -> Ensuring the call back does not fall into unloaded code which may > > cause > > > undefined behavior. > > > -> Ensuring the put_device() & module_put() code have finished in > > firmware_class.c > > > function request_firmware_work_func() before the device is > > unregistered > > > and module unloaded happen. > > > > Shouldn't the existing module_{put,get}() and {put,get}_device() calls > > provide all the necessary synchronisation? > > > > Module unload should not be possible while other code is using the > > module (and the module refcnt has been incremented accordindly). > > > > Right? > > > > -- > > Matt Fleming, Intel Open Source Technology Center > > Hi Matt, > > Yes, you are right. If the module refcount is not zero, you will get error > message and returned while you do "rmmod". But I strongly believe if we > have the capability in our code to take care of it by doing synchronization, > we should take care of it in case people are doing "rmmod -f". Don't > you think so? If you do 'rmmod -f' you get to keep all of the broken pieces of your kernel, no need to try to help out with crazy things like that. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/