Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbaKSFdn (ORCPT ); Wed, 19 Nov 2014 00:33:43 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:46680 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbaKSFdm (ORCPT ); Wed, 19 Nov 2014 00:33:42 -0500 Message-ID: <546C2B9E.3030204@ti.com> Date: Wed, 19 Nov 2014 11:03:18 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Heikki Krogerus CC: Vivek Gautam , Vivek Gautam , "linux-kernel@vger.kernel.org" , Linux USB Mailing List , Subject: Re: [PATCHv4 2/6] phy: improved lookup method References: <1413556756-5050-1-git-send-email-heikki.krogerus@linux.intel.com> <1413556756-5050-3-git-send-email-heikki.krogerus@linux.intel.com> <5461AFD3.5020302@ti.com> <5461CDDF.4090209@ti.com> <20141117154028.GD7512@kuha.fi.intel.com> <546AD6D6.5070205@ti.com> <20141118153642.GA8881@kuha.fi.intel.com> In-Reply-To: <20141118153642.GA8881@kuha.fi.intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 18 November 2014 09:06 PM, Heikki Krogerus wrote: > On Tue, Nov 18, 2014 at 10:49:18AM +0530, Kishon Vijay Abraham I wrote: >> On Monday 17 November 2014 09:10 PM, Heikki Krogerus wrote: >>> On Thu, Nov 13, 2014 at 07:03:01PM +0530, Vivek Gautam wrote: >>>> How about adding the change in attached patch [1] on top of this patch. >>>> Just introduced the phy pointer in "phy_lookup" structure, and >>>> modified phy_find() accordingly. >>> >>> I would be fine if we used the phy pointer to match, but if we have >>> the pointer to the phy in the lookup, then I would say we need to >>> remove the phy_name member. >>> >>> Otherwise we would have to support two ways of finding the lookups >>> (one for the "static" lookups where we match to the phy_name and other >>> where we match to the pointer). That means we will also not be able to >>> create "static" lookups, but those would be only needed if we wanted to >>> create them in board files. I don't think there will ever be need to >>> create the lookups in board files, so I'm more then happy to remove >>> the static way of creating the lookups. >> >> Just using the phy pointer sounds good. But interested to know where the phy >> pointer will be added to the lookup table. > > I'm making assumption that there will not be any (new) platforms where > the bindings are not provided in HW descriptions like dt or ACPI > tables. That leaves the lookups to be useful only in cases where a > driver has to, for whatever reason, pass it's phy's forward, like > dwc3 host. ULPI will be an other case where we will need to use them. right. > > Now the only user for the lookups is twl4030-usb, but since it's > actually just ULPI type PHY in cases where we have platform data to > deal with (please correct me if I'm wrong), I think we could later you mean passing consumer information using platform data? > remove it's need for platform data completely with the help of the > ULPI bus I'm working with. Sure. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/