Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755932AbaKSO5r (ORCPT ); Wed, 19 Nov 2014 09:57:47 -0500 Received: from mail-lb0-f178.google.com ([209.85.217.178]:53535 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754627AbaKSO5p convert rfc822-to-8bit (ORCPT ); Wed, 19 Nov 2014 09:57:45 -0500 MIME-Version: 1.0 In-Reply-To: <1416404939-365-1-git-send-email-lee.jones@linaro.org> References: <1416404939-365-1-git-send-email-lee.jones@linaro.org> Date: Wed, 19 Nov 2014 12:57:44 -0200 Message-ID: Subject: Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM From: Fabio Estevam To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , linux-kernel , edubezval@gmail.com, kernel@stlinux.com, "linux-pm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 19, 2014 at 11:48 AM, Lee Jones wrote: > Prevents build warning: > > st_thermal.c:278:12: > warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function] > st_thermal.c:286:12: > warning: ‘st_thermal_resume’ defined but not used [-Wunused-function] > > Signed-off-by: Lee Jones > --- > drivers/thermal/st/st_thermal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c > index 90163b3..9841488 100644 > --- a/drivers/thermal/st/st_thermal.c > +++ b/drivers/thermal/st/st_thermal.c > @@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev) > } > EXPORT_SYMBOL_GPL(st_thermal_unregister); > > +#ifdef CONFIG_PM Actually this should be #ifdef CONFIG_PM_SLEEP instead -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/