Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756002AbaKSPne (ORCPT ); Wed, 19 Nov 2014 10:43:34 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:40027 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755541AbaKSPnb (ORCPT ); Wed, 19 Nov 2014 10:43:31 -0500 Message-ID: <546CBA98.1040607@kapsi.fi> Date: Wed, 19 Nov 2014 17:43:20 +0200 From: Mikko Perttunen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Eduardo Valentin , Linux PM CC: Caesar Wang , Wei Ni , Lukasz Majewski , Alexandre Courbot , devicetree@vger.kernel.org, Grant Likely , Guenter Roeck , Jean Delvare , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, lm-sensors@lm-sensors.org, Rob Herring , Stephen Warren , Thierry Reding , Zhang Rui Subject: Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API References: <1416321575-18348-1-git-send-email-edubezval@gmail.com> <1416321575-18348-2-git-send-email-edubezval@gmail.com> <546CBA3C.9020709@kapsi.fi> In-Reply-To: <546CBA3C.9020709@kapsi.fi> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:708:30:12d0:beee:7bff:fe5b:f272 X-SA-Exim-Mail-From: mikko.perttunen@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/2014 05:41 PM, Mikko Perttunen wrote: > On 11/18/2014 04:39 PM, Eduardo Valentin wrote: >> Different drivers request API extensions in of-thermal. For this reason, >> additional callbacks are required to fit the new drivers needs. >> >> The current API implementation expects the registering sensor driver >> to provide a get_temp and get_trend callbacks as function parameters. >> As the amount of callbacks is growing, this patch changes the existing >> implementation to use a .ops field to hold all the of thermal callbacks >> to sensor drivers. >> >> This patch also changes the existing of-thermal users to fit the new >> API design. No functional change is introduced in this patch. >> >> Cc: Alexandre Courbot >> Cc: devicetree@vger.kernel.org >> Cc: Grant Likely >> Cc: Guenter Roeck >> Cc: Jean Delvare >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-pm@vger.kernel.org >> Cc: linux-tegra@vger.kernel.org >> Cc: lm-sensors@lm-sensors.org >> Cc: Rob Herring >> Cc: Stephen Warren >> Cc: Thierry Reding >> Cc: Zhang Rui >> Reviewed-by: Lukasz Majewski >> Signed-off-by: Eduardo Valentin >> --- >> drivers/hwmon/lm75.c | 9 +++-- >> drivers/hwmon/ntc_thermistor.c | 6 +++- >> drivers/hwmon/tmp102.c | 6 +++- >> drivers/thermal/of-thermal.c | 40 >> ++++++++++------------ >> drivers/thermal/tegra_soctherm.c | 7 ++-- >> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 8 +++-- >> include/linux/thermal.h | 24 +++++++++---- >> 7 files changed, 63 insertions(+), 37 deletions(-) >> --- >> Difference from V3: >> - Keep the same behavior regarding callback checks. >> Change in behavior may be sent in a separate patch. >> Difference from V2: >> - Fix wrong assignment in tegra driver. >> Difference from V1: >> - Fix error handling when .get_trend is not provided. >> >> @@ -356,8 +356,8 @@ thermal_zone_of_add_sensor(struct device_node *zone, >> * than one sensors >> * @data: a private pointer (owned by the caller) that will be passed >> * back, when a temperature reading is needed. >> - * @get_temp: a pointer to a function that reads the sensor temperature. >> - * @get_trend: a pointer to a function that reads the sensor >> temperature trend. >> + * @ops: struct thermal_zone_of_device *. Must contain at least >> .get_trend and >> + * .get_temp. > > This comment seems to be incorrect, as .get_trend is optional. Also, the parameter is of type struct thermal_zone_of_device_ops *, not just thermal_zone_of_device. > >> * >> * This function will search the list of thermal zones described in >> device >> * tree and look for the zone that refer to the sensor device >> pointed by > > With that minor one fixed, > > Tested-by: Mikko Perttunen > Reviewed-by: Mikko Perttunen > > Cheers, > Mikko > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/