Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932096AbaKSPuD (ORCPT ); Wed, 19 Nov 2014 10:50:03 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:34735 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754351AbaKSPuA (ORCPT ); Wed, 19 Nov 2014 10:50:00 -0500 Date: Wed, 19 Nov 2014 15:49:54 +0000 From: Lee Jones To: Fabio Estevam Cc: "linux-arm-kernel@lists.infradead.org" , linux-kernel , edubezval@gmail.com, kernel@stlinux.com, "linux-pm@vger.kernel.org" Subject: Re: [PATCH] thermal: sti: Ignore suspend/resume functions when !PM Message-ID: <20141119154954.GB1875@x1> References: <1416404939-365-1-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Nov 2014, Fabio Estevam wrote: > On Wed, Nov 19, 2014 at 11:48 AM, Lee Jones wrote: > > Prevents build warning: > > > > st_thermal.c:278:12: > > warning: ‘st_thermal_suspend’ defined but not used [-Wunused-function] > > st_thermal.c:286:12: > > warning: ‘st_thermal_resume’ defined but not used [-Wunused-function] > > > > Signed-off-by: Lee Jones > > --- > > drivers/thermal/st/st_thermal.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c > > index 90163b3..9841488 100644 > > --- a/drivers/thermal/st/st_thermal.c > > +++ b/drivers/thermal/st/st_thermal.c > > @@ -275,6 +275,7 @@ int st_thermal_unregister(struct platform_device *pdev) > > } > > EXPORT_SYMBOL_GPL(st_thermal_unregister); > > > > +#ifdef CONFIG_PM > > Actually this should be #ifdef CONFIG_PM_SLEEP instead You're right, someone already pointed this out, thanks. I will re-submit in ~1min. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/