Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756538AbaKSSCg (ORCPT ); Wed, 19 Nov 2014 13:02:36 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:48491 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756443AbaKSSCf (ORCPT ); Wed, 19 Nov 2014 13:02:35 -0500 Message-ID: <546CDB26.9030609@ti.com> Date: Wed, 19 Nov 2014 13:02:14 -0500 From: Murali Karicheri User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Dmitry Torokhov CC: Bjorn Helgaas , Arnd Bergmann , Wolfram Sang , , , Subject: Re: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map References: <20141114221903.GA38539@dtor-ws> In-Reply-To: <20141114221903.GA38539@dtor-ws> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/2014 05:19 PM, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov > --- > > Not tested, found by casual code inspection. > > drivers/pci/host/pci-keystone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c > index 8a27078..f2bd48d 100644 > --- a/drivers/pci/host/pci-keystone.c > +++ b/drivers/pci/host/pci-keystone.c > @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie, > */ > for (temp = 0; temp< max_host_irqs; temp++) { > host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp); > - if (host_irqs[temp]< 0) > + if (!host_irqs[temp]) > break; > } > if (temp) { Good catch! Acked-By: Murali Karicheri -- Murali Karicheri Linux Kernel, Texas Instruments -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/