Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756602AbaKSTXr (ORCPT ); Wed, 19 Nov 2014 14:23:47 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:47683 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755995AbaKSTXe (ORCPT ); Wed, 19 Nov 2014 14:23:34 -0500 MIME-Version: 1.0 In-Reply-To: <20141119183921.GF37989@dtor-ws> References: <20141114222640.GA39748@dtor-ws> <20141119181247.GE37989@dtor-ws> <20141119183921.GF37989@dtor-ws> Date: Wed, 19 Nov 2014 20:23:32 +0100 Message-ID: Subject: Re: [git pull] Input updates for 3.18-rc4 From: Marcus Overhagen To: Dmitry Torokhov Cc: Benjamin Tissoires , Ulrik De Bie , Hans de Goede , "linux-kernel@vger.kernel.org" , linux-input , Jiri Kosina Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, luckily I found some time right now. I haven't reverted the original large patch, but I tested your short patch and it fixes the problem for me. regards Marcus On Wed, Nov 19, 2014 at 7:39 PM, Dmitry Torokhov wrote: > On Wed, Nov 19, 2014 at 07:20:21PM +0100, Marcus Overhagen wrote: >> Hi, >> >> I will try reverting that, but may need until tomorrow or Friday. >> >> Just now I made a warm reboot from rc3 to rc5 and initially scrolling >> behaviour was ok, but after about a minute it went wrong and I got >> this: >> >> [ 179.705362] ------------[ cut here ]------------ >> [ 179.705382] WARNING: CPU: 3 PID: 0 at >> drivers/input/mouse/elantech.c:433 >> elantech_report_trackpoint.isra.5+0x199/0x1b0 [psmouse]() >> [ 179.705385] psmouse serio1: elantech: Unexpected trackpoint message > > Or just this for now: > > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c > index 3fcb6b3..294f613 100644 > --- a/drivers/input/mouse/elantech.c > +++ b/drivers/input/mouse/elantech.c > @@ -793,7 +793,7 @@ static int elantech_packet_check_v4(struct psmouse *psmouse) > unsigned char packet_type = packet[3] & 0x03; > bool sanity_check; > > - if ((packet[3] & 0x0f) == 0x06) > + if ((packet[3] & 0x0f) == 0x06 && etd->tp_dev) > return PACKET_TRACKPOINT; > > /* > > -- > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/