Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932478AbaKSVpg (ORCPT ); Wed, 19 Nov 2014 16:45:36 -0500 Received: from 1wt.eu ([62.212.114.60]:55765 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932748AbaKSVKz (ORCPT ); Wed, 19 Nov 2014 16:10:55 -0500 Date: Wed, 19 Nov 2014 22:10:49 +0100 From: Willy Tarreau To: Mariusz Gorski Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state Message-ID: <20141119211049.GD30756@1wt.eu> References: <1416429531-11088-1-git-send-email-marius.gorski@gmail.com> <1416429531-11088-5-git-send-email-marius.gorski@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416429531-11088-5-git-send-email-marius.gorski@gmail.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote: > Avoid magic number and use a comparison with a defined value instead > that checks whether module param has been set by the user to some > value at loading time. > > Signed-off-by: Mariusz Gorski Acked-by: Willy Tarreau -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/