Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756352AbaKTBBb (ORCPT ); Wed, 19 Nov 2014 20:01:31 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:45823 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbaKTBB3 convert rfc822-to-8bit (ORCPT ); Wed, 19 Nov 2014 20:01:29 -0500 References: <1416299826-15813-1-git-send-email-ethan.zhao@oracle.com> <1416299826-15813-7-git-send-email-ethan.zhao@oracle.com> <20141119105831.0428235f@kcaccard-desk.amr.corp.intel.com> Mime-Version: 1.0 (1.0) In-Reply-To: <20141119105831.0428235f@kcaccard-desk.amr.corp.intel.com> Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: 8BIT Message-Id: <7CC53F0F-7B2A-4915-8DC8-A2A5DC7C6930@gmail.com> Cc: Ethan Zhao , "" , "" , "" , "" , "" , "" , "" , "" , "" X-Mailer: iPad Mail (12B410) From: ethan Subject: Re: [PATCH 2/3] intel_pstate: allow driver to be built as a module Date: Thu, 20 Nov 2014 09:01:27 +0800 To: Kristen Carlson Accardi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kristen, > ?? 2014??11??20?գ?02:58??Kristen Carlson Accardi д???? > > On Tue, 18 Nov 2014 17:37:05 +0900 > Ethan Zhao wrote: > >> From: Brian Maly >> >> To provide the flexibility of module, allow this driver to >> be configured and built as a module. >> >> Signed-off-by: Brian Maly >> Signed-off-by: Ethan Zhao > > I believe the entire concept of being able to use intel_pstate as a > module just isn't going to work. There are load order issues - and > additionally the driver doesn't clean up after itself in any way. > Roger. Thanks, Ethan >> --- >> drivers/cpufreq/Kconfig.x86 | 2 +- >> drivers/cpufreq/intel_pstate.c | 6 ++++++ >> 2 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 >> index 89ae88f..94c9e6b 100644 >> --- a/drivers/cpufreq/Kconfig.x86 >> +++ b/drivers/cpufreq/Kconfig.x86 >> @@ -3,7 +3,7 @@ >> # >> >> config X86_INTEL_PSTATE >> - bool "Intel P state control" >> + tristate "Intel P state control" >> depends on X86 >> help >> This driver provides a P state for Intel core processors. >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c >> index 5498eb0..7c5faea 100644 >> --- a/drivers/cpufreq/intel_pstate.c >> +++ b/drivers/cpufreq/intel_pstate.c >> @@ -590,7 +590,9 @@ static void intel_pstate_set_pstate(struct cpudata *cpu, int pstate) >> if (pstate == cpu->pstate.current_pstate) >> return; >> >> +#ifndef MODULE >> trace_cpu_frequency(pstate * cpu->pstate.scaling, cpu->cpu); >> +#endif >> >> cpu->pstate.current_pstate = pstate; >> >> @@ -705,12 +707,14 @@ static void intel_pstate_timer_func(unsigned long __data) >> >> intel_pstate_adjust_busy_pstate(cpu); >> >> +#ifndef MODULE >> trace_pstate_sample(fp_toint(sample->core_pct_busy), >> fp_toint(intel_pstate_get_scaled_busy(cpu)), >> cpu->pstate.current_pstate, >> sample->mperf, >> sample->aperf, >> sample->freq); >> +#endif >> >> intel_pstate_set_sample_time(cpu); >> } >> @@ -1054,6 +1058,7 @@ out: >> } >> device_initcall(intel_pstate_init); >> >> +#ifndef MODULE >> static int __init intel_pstate_setup(char *str) >> { >> if (!str) >> @@ -1064,6 +1069,7 @@ static int __init intel_pstate_setup(char *str) >> return 0; >> } >> early_param("intel_pstate", intel_pstate_setup); >> +#endif >> >> MODULE_AUTHOR("Dirk Brandewie "); >> MODULE_DESCRIPTION("'intel_pstate' - P state driver Intel Core processors"); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/