Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757236AbaKTJTN (ORCPT ); Thu, 20 Nov 2014 04:19:13 -0500 Received: from mail-qa0-f43.google.com ([209.85.216.43]:47213 "EHLO mail-qa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757157AbaKTJTI (ORCPT ); Thu, 20 Nov 2014 04:19:08 -0500 MIME-Version: 1.0 In-Reply-To: <20141120084900.GC24143@lukather> References: <1412753937-29343-1-git-send-email-sonnyrao@chromium.org> <20141120084900.GC24143@lukather> From: Sonny Rao Date: Thu, 20 Nov 2014 01:18:46 -0800 X-Google-Sender-Auth: 4yeUdcGOujCOXgCSDVGDeA0ekLo Message-ID: Subject: Re: [PATCH v4] clocksource: arch_timer: Fix code to use physical timers when requested To: Maxime Ripard Cc: "linux-arm-kernel@lists.infradead.org" , Mark Rutland , Lorenzo Pieralisi , Russell King , Sudeep KarkadaNagesha , Catalin Marinas , Daniel Lezcano , Will Deacon , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Douglas Anderson , Marc Zyngier , Sudeep Holla , Olof Johansson , Thomas Gleixner , Stephen Boyd Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 20, 2014 at 12:49 AM, Maxime Ripard wrote: > Hi, > > On Wed, Oct 08, 2014 at 12:38:57AM -0700, Sonny Rao wrote: >> This is a bug fix for using physical arch timers when >> the arch_timer_use_virtual boolean is false. It restores the >> arch_counter_get_cntpct() function after removal in >> >> 0d651e4e "clocksource: arch_timer: use virtual counters" >> >> We need this on certain ARMv7 systems which are architected like this: >> >> * The firmware doesn't know and doesn't care about hypervisor mode and >> we don't want to add the complexity of hypervisor there. >> >> * The firmware isn't involved in SMP bringup or resume. >> >> * The ARCH timer come up with an uninitialized offset between the >> virtual and physical counters. Each core gets a different random >> offset. >> >> * The device boots in "Secure SVC" mode. >> >> * Nothing has touched the reset value of CNTHCTL.PL1PCEN or >> CNTHCTL.PL1PCTEN (both default to 1 at reset) >> >> One example of such as system is RK3288 where it is much simpler to >> use the physical counter since there's nobody managing the offset and >> each time a core goes down and comes back up it will get reinitialized >> to some other random value. >> >> Fixes: 0d651e4e65e9 ("clocksource: arch_timer: use virtual counters") >> Cc: stable@vger.kernel.org >> Signed-off-by: Sonny Rao >> Acked-by: Olof Johansson > > Has this been merged yet? > > If not, you can add my Tested-by, it makes the Allwinner A31 boot > flawlessly with the arch timers (together with the patch "clocksource: > arch_timer: Allow the device tree to specify uninitialized timer > registers") No, it has not been merged, and Doug just pinged Daniel about status on the other patch you mentioned. I'm glad these patches are useful to you another system, hopefully this will help the case for inclusion. Daniel, Mark, Will, others, is there any objection to this patch? If not could we please merge? > Thanks! > Maxime > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/