Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756868AbaKTNKI (ORCPT ); Thu, 20 Nov 2014 08:10:08 -0500 Received: from mail.eperm.de ([89.247.134.16]:54695 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbaKTNKG (ORCPT ); Thu, 20 Nov 2014 08:10:06 -0500 X-AuthUser: sm@eperm.de From: Stephan Mueller To: Herbert Xu Cc: Steffen Klassert , Daniel Borkmann , quentin.gouchet@gmail.com, LKML , linux-crypto@vger.kernel.org, ABI/API Subject: Re: crypto: user - Allow get request with empty driver name Date: Thu, 20 Nov 2014 14:10 +0100 Message-ID: <2283056.kKnMJs7Bfg@tachyon.chronox.de> User-Agent: KMail/4.14.3 (Linux/3.17.3-300.fc21.x86_64; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1706209.Hbu17X87TM@tachyon.chronox.de> References: <5365136.g8vbXlhRyC@tachyon.chronox.de> <20141120044650.GA28691@gondor.apana.org.au> <1706209.Hbu17X87TM@tachyon.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 20. November 2014, 14:02:21 schrieb Stephan Mueller: Hi Stephan, > Am Donnerstag, 20. November 2014, 12:46:50 schrieb Herbert Xu: > > Hi Herbert, > > > On Thu, Nov 20, 2014 at 05:23:23AM +0100, Stephan Mueller wrote: > > > Here is the code: > > > > > > static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr > > > *in_nlh, > > > > > > struct nlattr **attrs) > > > > > > { > > > ... > > > > > > if (!p->cru_driver_name[0]) > > > > > > return -EINVAL; > > > > OK let's fix this. > > > > crypto: user - Allow get request with empty driver name > > > > Currently all get requests with an empty driver name fail with > > EINVAL. Since most users actually want to supply an empty driver > > name this patch removes this check. > > > > Signed-off-by: Herbert Xu > > Acked-by: Stephan Mueller Although I acked the patch, it just occurred that your change modifies the user space interface such that you now cannot use a driver name any more. > > > diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c > > index e2a34fe..0bb30ac 100644 > > --- a/crypto/crypto_user.c > > +++ b/crypto/crypto_user.c > > @@ -201,10 +201,7 @@ static int crypto_report(struct sk_buff *in_skb, > > struct nlmsghdr *in_nlh, if (!null_terminated(p->cru_name) || > > !null_terminated(p->cru_driver_name)) return -EINVAL; > > > > - if (!p->cru_driver_name[0]) > > - return -EINVAL; > > - > > - alg = crypto_alg_match(p, 1); > > + alg = crypto_alg_match(p, 0); What about the following if (p->cru_driver_name[0] alg = crypto_alg_match(p, 1); else alg = crypto_alg_match(p, 0); > > > > if (!alg) > > > > return -ENOENT; > > > > Cheers, -- Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/