Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756826AbaKTNt6 (ORCPT ); Thu, 20 Nov 2014 08:49:58 -0500 Received: from mail-qg0-f50.google.com ([209.85.192.50]:56251 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756396AbaKTNty (ORCPT ); Thu, 20 Nov 2014 08:49:54 -0500 Date: Thu, 20 Nov 2014 09:49:52 -0400 From: Eduardo Valentin To: Mikko Perttunen Cc: Linux PM , Caesar Wang , Wei Ni , Lukasz Majewski , Alexandre Courbot , devicetree@vger.kernel.org, Grant Likely , Guenter Roeck , Jean Delvare , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, lm-sensors@lm-sensors.org, Rob Herring , Stephen Warren , Thierry Reding , Zhang Rui Subject: Re: [PATCHv4 1/1] thermal: of: improve of-thermal sensor registration API Message-ID: <20141120134950.GA24778@developer> References: <1416321575-18348-1-git-send-email-edubezval@gmail.com> <1416321575-18348-2-git-send-email-edubezval@gmail.com> <546CBA3C.9020709@kapsi.fi> <546CBA98.1040607@kapsi.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <546CBA98.1040607@kapsi.fi> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Mikko, On Wed, Nov 19, 2014 at 05:43:20PM +0200, Mikko Perttunen wrote: > On 11/19/2014 05:41 PM, Mikko Perttunen wrote: > > On 11/18/2014 04:39 PM, Eduardo Valentin wrote: > >> Different drivers request API extensions in of-thermal. For this reaso= n, > >> additional callbacks are required to fit the new drivers needs. > >> > >> The current API implementation expects the registering sensor driver > >> to provide a get_temp and get_trend callbacks as function parameters. > >> As the amount of callbacks is growing, this patch changes the existing > >> implementation to use a .ops field to hold all the of thermal callbacks > >> to sensor drivers. > >> > >> This patch also changes the existing of-thermal users to fit the new > >> API design. No functional change is introduced in this patch. > >> > >> Cc: Alexandre Courbot > >> Cc: devicetree@vger.kernel.org > >> Cc: Grant Likely > >> Cc: Guenter Roeck > >> Cc: Jean Delvare > >> Cc: linux-kernel@vger.kernel.org > >> Cc: linux-pm@vger.kernel.org > >> Cc: linux-tegra@vger.kernel.org > >> Cc: lm-sensors@lm-sensors.org > >> Cc: Rob Herring > >> Cc: Stephen Warren > >> Cc: Thierry Reding > >> Cc: Zhang Rui > >> Reviewed-by: Lukasz Majewski > >> Signed-off-by: Eduardo Valentin > >> --- > >> drivers/hwmon/lm75.c | 9 +++-- > >> drivers/hwmon/ntc_thermistor.c | 6 +++- > >> drivers/hwmon/tmp102.c | 6 +++- > >> drivers/thermal/of-thermal.c | 40 > >> ++++++++++------------ > >> drivers/thermal/tegra_soctherm.c | 7 ++-- > >> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 8 +++-- > >> include/linux/thermal.h | 24 +++++++++---- > >> 7 files changed, 63 insertions(+), 37 deletions(-) > >> --- > >> Difference from V3: > >> - Keep the same behavior regarding callback checks. > >> Change in behavior may be sent in a separate patch. > >> Difference from V2: > >> - Fix wrong assignment in tegra driver. > >> Difference from V1: > >> - Fix error handling when .get_trend is not provided. > >> > >> @@ -356,8 +356,8 @@ thermal_zone_of_add_sensor(struct device_node *zon= e, > >> * than one sensors > >> * @data: a private pointer (owned by the caller) that will be passed > >> * back, when a temperature reading is needed. > >> - * @get_temp: a pointer to a function that reads the sensor temperatu= re. > >> - * @get_trend: a pointer to a function that reads the sensor > >> temperature trend. > >> + * @ops: struct thermal_zone_of_device *. Must contain at least > >> .get_trend and > >> + * .get_temp. > > > > This comment seems to be incorrect, as .get_trend is optional. >=20 > Also, the parameter is of type struct thermal_zone_of_device_ops *, not= =20 > just thermal_zone_of_device. >=20 > > > >> * > >> * This function will search the list of thermal zones described in > >> device > >> * tree and look for the zone that refer to the sensor device > >> pointed by > > > > With that minor one fixed, > > > > Tested-by: Mikko Perttunen > > Reviewed-by: Mikko Perttunen All the comments fixed now. Thanks for reviewing and testing. > > > > Cheers, > > Mikko > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-tegra" = in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20 Cheers, Eduardo Valentin --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUbfF+AAoJEMLUO4d9pOJW8IEIAJvMZe9zKr47JQ8oKOHRurmp rcR9eLeTW1spgbpXC4IOtOz6wzVbkUHsc3rODShgjXx17w7bCS/3zRXlWQ9b8teF Hh3U8+7u1vFK7Pw0EM6kiKYXiL+pNyUdAXOKpUKyJlCG7oQRNS47LGGkvIpCPZoU fJCXWC033V9ZyYY53kZe9e15Vj7nHYb9XwEu80H8ncaJ0KjcEZO6f/DHlZxoA98v UUkhsPLsZ5TURJiM4EPikFaqLKjpsKoJvsSB2pzjeiZfpiASVem3+mLuu7vYYRBT ZNkCkJY18s41Tz10OxVmUxLQcA6xId0jPXIBLqV77e/m3Bg3/oPe3jVGdMSpq7A= =VrjL -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/