Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757152AbaKTPUc (ORCPT ); Thu, 20 Nov 2014 10:20:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54525 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754127AbaKTPUb (ORCPT ); Thu, 20 Nov 2014 10:20:31 -0500 Date: Thu, 20 Nov 2014 09:19:54 -0600 From: Josh Poimboeuf To: Seth Jennings Cc: Jiri Kosina , Vojtech Pavlik , Steven Rostedt , Petr Mladek , Miroslav Benes , Christoph Hellwig , Greg KH , Andy Lutomirski , Masami Hiramatsu , live-patching@vger.kernel.org, x86@kernel.org, kpatch@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/3] kernel: add support for live patching Message-ID: <20141120151954.GB3370@treble.redhat.com> References: <1416187764-3341-1-git-send-email-sjenning@redhat.com> <1416187764-3341-3-git-send-email-sjenning@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1416187764-3341-3-git-send-email-sjenning@redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: > +static int lpc_module_notify(struct notifier_block *nb, unsigned long action, > + void *data) > +{ > + struct module *mod = data; > + struct lpc_patch *patch; > + struct lpc_object *obj; > + > + mutex_lock(&lpc_mutex); > + > + if (action != MODULE_STATE_COMING && action != MODULE_STATE_GOING) > + goto out; I think we can get the mutex here instead of above so it doesn't block other module actions (and then you can also get rid of the "out" label). > + > + list_for_each_entry(patch, &lpc_patches, list) { > + if (patch->state == LPC_DISABLED) > + continue; > + list_for_each_entry(obj, &patch->objs, list) { > + if (strcmp(obj->name, mod->name)) > + continue; > + if (action == MODULE_STATE_COMING) { > + obj->mod = mod; > + lpc_module_notify_coming(patch->mod, obj); > + } else /* MODULE_STATE_GOING */ > + lpc_module_notify_going(patch->mod, obj); > + break; > + } > + } > +out: > + mutex_unlock(&lpc_mutex); > + return 0; > +} -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/