Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757501AbaKTQHv (ORCPT ); Thu, 20 Nov 2014 11:07:51 -0500 Received: from mail-qa0-f41.google.com ([209.85.216.41]:50740 "EHLO mail-qa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbaKTQHu (ORCPT ); Thu, 20 Nov 2014 11:07:50 -0500 Date: Thu, 20 Nov 2014 11:07:46 -0500 From: Tejun Heo To: Petr Mladek Cc: Rusty Russell , "Michael S. Tsirkin" , Jeff Epler , Jiri Kosina , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] virtio_balloon: Convert "vballoon" kthread into a workqueue Message-ID: <20141120160746.GI14877@htj.dyndns.org> References: <1416499397-16669-1-git-send-email-pmladek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416499397-16669-1-git-send-email-pmladek@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 20, 2014 at 05:03:17PM +0100, Petr Mladek wrote: ... > @@ -476,7 +460,6 @@ static void virtballoon_remove(struct virtio_device *vdev) > { > struct virtio_balloon *vb = vdev->priv; > > - kthread_stop(vb->thread); > remove_common(vb); > kfree(vb); > } Shouldn't the work item be flushed before removal is complete? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/