Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757725AbaKTSBE (ORCPT ); Thu, 20 Nov 2014 13:01:04 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:60093 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754913AbaKTSBB (ORCPT ); Thu, 20 Nov 2014 13:01:01 -0500 From: Arianna Avanzini To: gregkh@linuxfoundation.org, jslaby@suse.cz, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: avanzini.arianna@gmail.com Subject: [PATCH RFC] tty, serial, 8250: remove __init from function serial8250_console_setup() Date: Thu, 20 Nov 2014 19:00:56 +0100 Message-Id: <1416506456-2126-1-git-send-email-avanzini.arianna@gmail.com> X-Mailer: git-send-email 2.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some RS232 adapters handled by this driver are hotpluggable. The function serial8250_console_setup() is called during device init and is defined with the __init macro. In case the driver is built-in, hotplugging the device after the initialization phase has been completed (and the related memory has been freed) results in a kernel crash. This commit fixes the issue by removing __init from the function definition. Signed-off-by: Arianna Avanzini --- drivers/tty/serial/8250/8250_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index ca5cfdc..ca8108d 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -3237,7 +3237,7 @@ serial8250_console_write(struct console *co, const char *s, unsigned int count) serial8250_rpm_put(up); } -static int __init serial8250_console_setup(struct console *co, char *options) +static int serial8250_console_setup(struct console *co, char *options) { struct uart_port *port; int baud = 9600; -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/