Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757987AbaKTUG7 (ORCPT ); Thu, 20 Nov 2014 15:06:59 -0500 Received: from resqmta-ch2-09v.sys.comcast.net ([69.252.207.41]:36472 "EHLO resqmta-ch2-09v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757959AbaKTUG5 (ORCPT ); Thu, 20 Nov 2014 15:06:57 -0500 Date: Thu, 20 Nov 2014 14:06:53 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: "Kirill A. Shutemov" cc: Jerome Marchand , "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Dave Hansen , Hugh Dickins , Mel Gorman , Rik van Riel , Vlastimil Babka , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 06/19] mm: store mapcount for compound page separate In-Reply-To: <20141119130050.GA29884@node.dhcp.inet.fi> Message-ID: References: <1415198994-15252-1-git-send-email-kirill.shutemov@linux.intel.com> <1415198994-15252-7-git-send-email-kirill.shutemov@linux.intel.com> <546C761D.6050407@redhat.com> <20141119130050.GA29884@node.dhcp.inet.fi> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Nov 2014, Kirill A. Shutemov wrote: > I don't think we want to bloat struct page description: nobody outside of > helpers should use it direcly. And it's exactly what we did to store > compound page destructor and compound page order. This is more like a description what overloading is occurring. Either add the new way of using it there including a comment explainng things or please do not overload the field. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/