Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753350AbaKUF1c (ORCPT ); Fri, 21 Nov 2014 00:27:32 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:52418 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbaKUF1b (ORCPT ); Fri, 21 Nov 2014 00:27:31 -0500 Date: Fri, 21 Nov 2014 00:27:28 -0500 (EST) Message-Id: <20141121.002728.487856666097568926.davem@davemloft.net> To: jasowang@redhat.com Cc: rusty@rustcorp.com.au, mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cornelia.huck@de.ibm.com, gaowanlong@cn.fujitsu.com Subject: Re: [PATCH net V5] virtio-net: validate features during probe From: David Miller In-Reply-To: <1416474185-10981-1-git-send-email-jasowang@redhat.com> References: <1416474185-10981-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 20 Nov 2014 21:27:30 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Thu, 20 Nov 2014 17:03:05 +0800 > We currently trigger BUG when VIRTIO_NET_F_CTRL_VQ > is not set but one of features depending on it is. > That's not a friendly way to report errors to > hypervisors. > Let's check, and fail probe instead. > > Cc: Rusty Russell > Cc: Cornelia Huck > Cc: Wanlong Gao > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Jason Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/