From: Yuantian Tang <Yuantian.Tang@freescale.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
        "Jason.Jin@freescale.com" <Jason.Jin@freescale.com>
Subject: RE: [PATCH 2/2] cpufreq: qoriq: rename the driver
Thread-Topic: [PATCH 2/2] cpufreq: qoriq: rename the driver
Thread-Index: AQHQBVzhF5TdVORmqkCz8HfXsQR2dJxqtngAgAAVqvA=
Date: Fri, 21 Nov 2014 09:16:23 +0000
Message-ID: <dedc11e3150d44ee89bb1e96b5447687@DM2PR03MB574.namprd03.prod.outlook.com>
References: <1416554882-16566-1-git-send-email-Yuantian.Tang@freescale.com>
	<1416554882-16566-2-git-send-email-Yuantian.Tang@freescale.com>
 <CAKohpo=xLOxXrCJNO0LmrVxMDNsFy2Kxg6bNzHm=vQCJnBvSaw@mail.gmail.com>
In-Reply-To: <CAKohpo=xLOxXrCJNO0LmrVxMDNsFy2Kxg6bNzHm=vQCJnBvSaw@mail.gmail.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit

Hello Viresh,

When I use -C -M options, checkpatch reports error:

[tangyt@titan linux-pm]$ ./scripts/checkpatch.pl 0002-cpufreq-qoriq-rename-the-driver.patch 
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
 drivers/cpufreq/{ppc-corenet-cpufreq.c => qoriq-cpufreq.c} | 0

ERROR: Does not appear to be a unified-diff format patch

total: 1 errors, 1 warnings, 0 lines checked

0002-cpufreq-qoriq-rename-the-driver.patch has style problems, please review.

I just rename it and do not change anyting. Isn't that allowed?

Thanks,
Yuantian

> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar@linaro.org]
> Sent: Friday, November 21, 2014 3:56 PM
> To: Tang Yuantian-B29983
> Cc: Rafael J. Wysocki; Linux Kernel Mailing List; linux-pm@vger.kernel.org;
> linuxppc-dev@ozlabs.org; Jin Zhengxiong-R64188
> Subject: Re: [PATCH 2/2] cpufreq: qoriq: rename the driver
> 
> On 21 November 2014 12:58, Tang Yuantian <Yuantian.Tang@freescale.com>
> wrote:
> > This driver works on all QorIQ platforms which include ARM-based cores
> > and PPC-based cores.
> > Rename it in order to represent better.
> >
> > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > ---
> >  drivers/cpufreq/ppc-corenet-cpufreq.c | 371 ----------------------------------
> >  drivers/cpufreq/qoriq-cpufreq.c       | 371
> ++++++++++++++++++++++++++++++++++
> >  2 files changed, 371 insertions(+), 371 deletions(-)  delete mode
> > 100644 drivers/cpufreq/ppc-corenet-cpufreq.c
> >  create mode 100644 drivers/cpufreq/qoriq-cpufreq.c
> 
> This is not reviewable at all.. How do I verify that you haven't changed something
> in the files as well ?
> 
> To make life easy always create patches with:
> 
> git format-patch -C -M
> 
> Above options handle renames pretty well.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?