Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758396AbaKUMeX (ORCPT ); Fri, 21 Nov 2014 07:34:23 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:36553 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758337AbaKUMeV (ORCPT ); Fri, 21 Nov 2014 07:34:21 -0500 Date: Fri, 21 Nov 2014 12:35:09 +0000 From: Morten Rasmussen To: Vincent Guittot Cc: "peterz@infradead.org" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "preeti@linux.vnet.ibm.com" , "kamalesh@linux.vnet.ibm.com" , "linux-arm-kernel@lists.infradead.org" , "riel@redhat.com" , "efault@gmx.de" , "nicolas.pitre@linaro.org" , "linaro-kernel@lists.linaro.org" , Paul Turner , Ben Segall Subject: Re: [PATCH v9 02/10] sched: Track group sched_entity usage contributions Message-ID: <20141121123509.GC23177@e105550-lin.cambridge.arm.com> References: <1415033687-23294-1-git-send-email-vincent.guittot@linaro.org> <1415033687-23294-3-git-send-email-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1415033687-23294-3-git-send-email-vincent.guittot@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org s/usage/utilization/ in subject. On Mon, Nov 03, 2014 at 04:54:39PM +0000, Vincent Guittot wrote: > From: Morten Rasmussen > > Adds usage contribution tracking for group entities. Unlike s/usage contribution/utilization/ > se->avg.load_avg_contrib, se->avg.utilization_avg_contrib for group > entities is the sum of se->avg.utilization_avg_contrib for all entities on the > group runqueue. It is _not_ influenced in any way by the task group > h_load. Hence it is representing the actual cpu usage of the group, not s/usage/utilization/ > its intended load contribution which may differ significantly from the > utilization on lightly utilized systems. > > cc: Paul Turner > cc: Ben Segall > > Signed-off-by: Morten Rasmussen > Signed-off-by: Vincent Guittot > --- > kernel/sched/debug.c | 2 ++ > kernel/sched/fair.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > index f384452..efb47ed 100644 > --- a/kernel/sched/debug.c > +++ b/kernel/sched/debug.c > @@ -94,8 +94,10 @@ static void print_cfs_group_stats(struct seq_file *m, int cpu, struct task_group > P(se->load.weight); > #ifdef CONFIG_SMP > P(se->avg.runnable_avg_sum); > + P(se->avg.running_avg_sum); > P(se->avg.avg_period); > P(se->avg.load_avg_contrib); > + P(se->avg.utilization_avg_contrib); > P(se->avg.decay_count); > #endif > #undef PN > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 3a91ae6..a171e1b 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -2529,6 +2529,9 @@ static long __update_entity_utilization_avg_contrib(struct sched_entity *se) > > if (entity_is_task(se)) > __update_task_entity_utilization(se); > + else > + se->avg.utilization_avg_contrib = > + group_cfs_rq(se)->utilization_load_avg; > > return se->avg.utilization_avg_contrib - old_contrib; > } What happened to the update of se->avg.utilization_avg_contrib in __synchronize_entity_decay()? It seems to have disapperead after v7. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/