Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758703AbaKUPHR (ORCPT ); Fri, 21 Nov 2014 10:07:17 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:49638 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758358AbaKUPHH (ORCPT ); Fri, 21 Nov 2014 10:07:07 -0500 From: Pranith Kumar To: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 3/9] dcache: Replace smp_read_barrier_depends() with lockless_dereference() Date: Fri, 21 Nov 2014 10:05:57 -0500 Message-Id: <1416582363-20661-4-git-send-email-bobby.prani@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1416582363-20661-1-git-send-email-bobby.prani@gmail.com> References: <1416582363-20661-1-git-send-email-bobby.prani@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Recently lockless_dereference() was added which can be used in place of hard-coding smp_read_barrier_depends(). The following PATCH makes the change. Signed-off-by: Pranith Kumar --- fs/dcache.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index a6c5d7e..27b8b5b 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -230,8 +230,7 @@ static inline int dentry_cmp(const struct dentry *dentry, const unsigned char *c * early because the data cannot match (there can * be no NUL in the ct/tcount data) */ - cs = ACCESS_ONCE(dentry->d_name.name); - smp_read_barrier_depends(); + cs = lockless_dereference(dentry->d_name.name); return dentry_string_cmp(cs, ct, tcount); } @@ -2714,10 +2713,8 @@ static int prepend(char **buffer, int *buflen, const char *str, int namelen) static int prepend_name(char **buffer, int *buflen, struct qstr *name) { const char *dname = ACCESS_ONCE(name->name); - u32 dlen = ACCESS_ONCE(name->len); char *p; - - smp_read_barrier_depends(); + u32 dlen = lockless_dereference(name->len); *buflen -= dlen + 1; if (*buflen < 0) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/