Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758722AbaKUP3n (ORCPT ); Fri, 21 Nov 2014 10:29:43 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:58044 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755341AbaKUP32 (ORCPT ); Fri, 21 Nov 2014 10:29:28 -0500 Date: Fri, 21 Nov 2014 15:29:09 +0000 From: Russell King - ARM Linux To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, konrad.wilk@oracle.com, Ian Campbell , david.vrabel@citrix.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com Subject: Re: [PATCH v9 05/13] arm: introduce is_device_dma_coherent Message-ID: <20141121152908.GU4042@n2100.arm.linux.org.uk> References: <1415792454-23161-5-git-send-email-stefano.stabellini@eu.citrix.com> <20141120000736.GN4042@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 20, 2014 at 10:39:32AM +0000, Stefano Stabellini wrote: > On Thu, 20 Nov 2014, Russell King - ARM Linux wrote: > > On Tue, Nov 18, 2014 at 04:49:21PM +0000, Stefano Stabellini wrote: > > > ping? > > > > Sending something which wants my attention _To:_ me is always a good idea :) > > I'll keep that in mind :-) > > > > The patch is fine in itself, but I have a niggle about the > > is_device_dma_coherent() - provided this is only used in architecture > > specific code, that should be fine. It could probably do with a comment > > to that effect in an attempt to discourage drivers using it (thereby > > becoming less portable to other architectures.) > > Can I take this as an Acked-by? > Good point regarding the comment. Maybe I can add: > > /* do not use this function in a driver */ Provided it gets such a comment, yes. Thanks. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/