Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbaKVBAw (ORCPT ); Fri, 21 Nov 2014 20:00:52 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34681 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbaKVBAt (ORCPT ); Fri, 21 Nov 2014 20:00:49 -0500 MIME-Version: 1.0 In-Reply-To: <1415956110.2640.5.camel@linux-0dmf.site> References: <1415909806-23848-1-git-send-email-bleung@chromium.org> <1415956110.2640.5.camel@linux-0dmf.site> Date: Fri, 21 Nov 2014 17:00:49 -0800 X-Google-Sender-Auth: Ah23Hho7pu5srj2_VxaoeldTxz4 Message-ID: Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup From: Benson Leung To: Oliver Neukum Cc: johan@kernel.org, Jiri Kosina , linux-usb@vger.kernel.org, "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sameer Nanda Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 14, 2014 at 1:08 AM, Oliver Neukum wrote: > On Thu, 2014-11-13 at 12:16 -0800, Benson Leung wrote: > >> In usbhid_open, usb_autopm_get_interface is called >> before setting the needs_remote_wakeup flag, and >> usb_autopm_put_interface is called after hid_start_in. >> >> However, when the device is closed in usbhid_close, the same >> protection isn't there when clearing needs_remote_wakeup. This will >> add that to usbhid_close as well as usbhid_stop. > > Interesting, but this has the side effect of waking devices > that are asleep just to remove the flag. > > Regards If devices are already asleep with this flag enabled, that means that they are presently configured for remote wake. Waking the device in the case of a close() is appropriate because it also has the effect of re-suspending the device with the capability disabled, as it is no longer necessary. -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/