Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915AbaKVQA2 (ORCPT ); Sat, 22 Nov 2014 11:00:28 -0500 Received: from mail-ob0-f178.google.com ([209.85.214.178]:44900 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbaKVQA0 (ORCPT ); Sat, 22 Nov 2014 11:00:26 -0500 MIME-Version: 1.0 In-Reply-To: <20141122111444.GA12445@pd.tnic> References: <54705C8E.1080400@googlemail.com> <20141122111444.GA12445@pd.tnic> Date: Sat, 22 Nov 2014 08:00:26 -0800 X-Google-Sender-Auth: utkjiGyxqg6Eq-WQe9auaP-ZkJI Message-ID: Subject: Re: [PATCH]: cross-compiling x86_64 kernel on i386 user-space fails From: Kees Cook To: Borislav Petkov Cc: Chris Clayton , LKML , Junjie Mao , x86-ml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 22, 2014 at 3:14 AM, Borislav Petkov wrote: > On Sat, Nov 22, 2014 at 09:51:10AM +0000, Chris Clayton wrote: >> Hi, > > Yeah, next time make sure you actually CC people :-) > > I've added them to CC now. > >> Commit e6023367d779060fddc9a52d1f474085b2b36298 broke building an x86_64 kernel in an i386. The change added a call to >> objdump but neglected to cater for cross-compiling. >> >> The patch below fixes the problem for me. I see the commit is now in 3.14 and 3.17 -stable, so the patch needs to go >> there too. Good catch, thanks! > > CC: stable@vger.kernel.org > > in the commit message should help there. > > >> CC: Junjie Mao >> CC: Kees Cook >> CC: Thomas Gleixner >> CC: Ingo Molnar >> Signed-off-by: Chris Clayton > > Acked-by: Borislav Petkov Acked-by: Kees Cook -Kees > >> --- >> --- linux/arch/x86/boot/compressed/Makefile~ 2014-11-22 08:56:50.359706324 +0000 >> +++ linux/arch/x86/boot/compressed/Makefile 2014-11-22 09:04:06.615693435 +0000 >> @@ -76,7 +76,7 @@ suffix-$(CONFIG_KERNEL_XZ) := xz >> suffix-$(CONFIG_KERNEL_LZO) := lzo >> suffix-$(CONFIG_KERNEL_LZ4) := lz4 >> >> -RUN_SIZE = $(shell objdump -h vmlinux | \ >> +RUN_SIZE = $(shell ${CROSS_COMPILE}objdump -h vmlinux | \ >> perl $(srctree)/arch/x86/tools/calc_run_size.pl) >> quiet_cmd_mkpiggy = MKPIGGY $@ >> cmd_mkpiggy = $(obj)/mkpiggy $< $(RUN_SIZE) > $@ || ( rm -f $@ ; false ) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/