Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752206AbaKVQDA (ORCPT ); Sat, 22 Nov 2014 11:03:00 -0500 Received: from netrider.rowland.org ([192.131.102.5]:59948 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751275AbaKVQC7 (ORCPT ); Sat, 22 Nov 2014 11:02:59 -0500 Date: Sat, 22 Nov 2014 11:02:58 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Benson Leung cc: johan@kernel.org, Jiri Kosina , , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sameer Nanda Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Nov 2014, Alan Stern wrote: > There is no USB wrapper for pm_runtime_idle calls, but one could be > added. Still, in the meantime can you check to see what happens if you > add > > pm_runtime_idle(&usbhid->intf->dev); > > in usbhid_close() just after needs_remote_wakeup is set to 0? You can > do the same thing in usbhid_stop() if you want. Come to think of it, we probably need pm_runtime_idle(usbhid->intf->dev->parent); in addition to the function call above. When a USB wrapper is written, it can take care of these details. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/