Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752125AbaKVQ70 (ORCPT ); Sat, 22 Nov 2014 11:59:26 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:42552 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbaKVQ7Z (ORCPT ); Sat, 22 Nov 2014 11:59:25 -0500 Message-ID: <5470C0DB.9080900@pengutronix.de> Date: Sat, 22 Nov 2014 17:59:07 +0100 From: Marc Kleine-Budde User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Jeremiah Mahler , Oliver Hartkopp CC: "David S. Miller" , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: eliminate banner[] variable and switch to pr_info() References: <1416642155-31816-1-git-send-email-jmmahler@gmail.com> In-Reply-To: <1416642155-31816-1-git-send-email-jmmahler@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7KSnNMPQbH53b4pehpLxxXQNhAn3S8823" X-SA-Exim-Connect-IP: 2001:6f8:1178:4:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7KSnNMPQbH53b4pehpLxxXQNhAn3S8823 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/22/2014 08:42 AM, Jeremiah Mahler wrote: > Several CAN modules use a design pattern with a banner[] variable at th= e > top which defines a string that is used once during init to print the > banner. The string is also embedded with KERN_INFO which makes it > printk() specific. >=20 > Improve the code by eliminating the banner[] variable and moving the > string to where it is printed. Then switch from printk(KERN_INFO to > pr_info() for the lines that were changed. Applied to can-next. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --7KSnNMPQbH53b4pehpLxxXQNhAn3S8823 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUcMDeAAoJECte4hHFiupUbiIP/j/eSss/WXIZf/EaxW6cui8D un16nudHbCmfuVAjSkMF7Be/wwtsSy0W2KTSOGI+PfgzYeInEsT+rfdMMeGEpIom bQNsG9J8Uv6vf32KQAC4G+h1GRL8YdTeDIWceFNNKFbtYBKp4xa5m94bVkgWeK5s B4OsaLV1eQOiw+gRqjWWe0BHsFhVQc0ifndLhTgkEcDh8Bsq58AAX9mWul0THAs3 YJY1hbVu/lUTKkwahmvUS/5QcP0MjB9hUS/xBiCga4FNHvpu/XESZ97EjjZ10Xth BezRXcGNZCNZPzN/94aEGdQeZKg80vrfafjO8G9OHbFmozqR+TMT0RCwHq8+kTBa iDW9p+BUUyHeCcK9G6Q/m1F8MnSA2oGL0YZu6BzEAAWnXHaM9TPM9yi9zS/CzXAu c38Y//UyWM68ShUOE7Qlgpjxbm5Spgvsvir25lnVn9SspdD/iZ8kLgYt9Id214tU ewhfuaaFJNB+t0dc0/g+7BxA8p6RwwHQwFiOEVSgxMgfd4sGGOvjiqnJz77/Hm79 ixJO3YMJ6LmOVOTX1ydRzSJHaVlA26VreTZ/gBgvOJFwm6qGUIuT5iYVz5wLkgkz ke5QwkzbmOmnxGR+wSrHctWeWCMDTObCUbGil7c3KnPmS90CdGKvUxisdpxLdiRd z+MqaSKGKFVLE/qxxaUT =7+dH -----END PGP SIGNATURE----- --7KSnNMPQbH53b4pehpLxxXQNhAn3S8823-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/